Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 2789523002: Fix edge cases where a FormatException source argument starts with a newline. (Closed)

Created:
3 years, 8 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 8 months ago
Reviewers:
eernst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix edge cases where a FormatException source argument starts with a newline. Fixes #29195 BUG= http://dartbug.com/29195 R=eernst@google.com Committed: https://github.com/dart-lang/sdk/commit/c6ef4c8dd9957a74a5abdc2c253d1fdbbed82a88

Patch Set 1 #

Patch Set 2 : Rename variables. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M sdk/lib/core/exceptions.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/corelib/format_exception_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
3 years, 8 months ago (2017-03-30 09:34:08 UTC) #2
eernst
LGTM!
3 years, 8 months ago (2017-03-30 12:06:09 UTC) #3
Lasse Reichstein Nielsen
3 years, 8 months ago (2017-03-30 13:17:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c6ef4c8dd9957a74a5abdc2c253d1fdbbed82a88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698