Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 2789503002: Revert of [Offline pages] Integrate snapshot controller fully into background loader. (Closed)

Created:
3 years, 8 months ago by chili
Modified:
3 years, 8 months ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Offline pages] Integrate snapshot controller fully into background loader. (patchset #2 id:20001 of https://codereview.chromium.org/2769043002/ ) Reason for revert: Causes crash, crbug/706279 Original issue's description: > [Offline pages] Integrate snapshot controller fully into background loader. > > BUG=705753 > > Review-Url: https://codereview.chromium.org/2769043002 > Cr-Commit-Position: refs/heads/master@{#459967} > Committed: https://chromium.googlesource.com/chromium/src/+/e101d81bbdb680bd24286fab8d799c5116257744 TBR=petewil@chromium.org,fgorski@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=705753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -28 lines) Patch
M chrome/browser/android/offline_pages/background_loader_offliner.h View 5 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/android/offline_pages/background_loader_offliner.cc View 9 chunks +26 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
chili
Created Revert of [Offline pages] Integrate snapshot controller fully into background loader.
3 years, 8 months ago (2017-03-30 08:11:06 UTC) #1
chili
Reverting because fixing patch (https://codereview.chromium.org/2779983005/) is taking a little longer than expected
3 years, 8 months ago (2017-03-30 08:13:19 UTC) #3
chili
3 years, 8 months ago (2017-03-30 08:13:51 UTC) #5
Pete Williamson
3 years, 8 months ago (2017-03-30 17:35:15 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698