Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller_unittest.mm

Issue 2789433006: Implement request mobile site. (Closed)
Patch Set: Fix failing eg tests on iPad. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller_unittest.mm b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller_unittest.mm
index 3e2e9a1aa39ce9827482be284569d7b48cb261db..2a7d7a5ee783439b4bd1d04f1f504c1cb4899a0f 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller_unittest.mm
+++ b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller_unittest.mm
@@ -69,19 +69,19 @@ void SetUp() override {
EXPECT_FALSE(mobile_item);
}
-// Tests that "Request Desktop Site" is visible and not enabled, and
-// "Request Mobile Site" is invisible when the current page is a web page and
-// uses DESKTOP user agent.
+// Tests that "Request Desktop Site" is invisible, and "Request Mobile Site" is
+// visible and enabled when the current page is a web page and uses DESKTOP user
+// agent.
TEST_F(ToolsMenuViewControllerTest, TestUserAgentTypeDESKTOP) {
[configuration_ setUserAgentType:web::UserAgentType::DESKTOP];
[controller_ initializeMenuWithConfiguration:configuration_.get()];
ToolsMenuViewItem* desktop_item =
GetToolsMenuViewItemWithTag(IDC_REQUEST_DESKTOP_SITE);
- ASSERT_TRUE(desktop_item);
- EXPECT_FALSE(desktop_item.active);
+ EXPECT_FALSE(desktop_item);
ToolsMenuViewItem* mobile_item =
GetToolsMenuViewItemWithTag(IDC_REQUEST_MOBILE_SITE);
- EXPECT_FALSE(mobile_item);
+ ASSERT_TRUE(mobile_item);
+ EXPECT_TRUE(mobile_item.active);
}

Powered by Google App Engine
This is Rietveld 408576698