Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 278943002: Use real revision mapping in bot_update module (Closed)

Created:
6 years, 7 months ago by iannucci
Modified:
6 years, 7 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Visibility:
Public.

Description

Use real revision mapping in bot_update module R=hinoka@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269436

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 5

Patch Set 3 : re-upload #

Patch Set 4 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -15 lines) Patch
M scripts/slave/bot_update.py View 1 2 3 2 chunks +17 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/android/example.expected/basic.json View 1 2 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/bot_update/api.py View 1 3 chunks +7 lines, -12 lines 0 comments Download
M scripts/slave/recipe_modules/bot_update/example.expected/basic.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/bot_update/example.expected/tryjob.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android_webview_aosp.expected/basic.json View 1 2 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android_webview_aosp.expected/does_delete_stale_chromium.json View 1 2 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android_webview_aosp.expected/doesnt_sync_if_android_present.json View 1 2 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android_webview_aosp.expected/trybot.json View 1 2 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android_webview_aosp.expected/uses_android_repo.json View 1 2 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android_webview_aosp.expected/uses_goma_test.json View 1 2 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android_webview_aosp.expected/works_if_revision_not_present.json View 1 2 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_gtest.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_ChromeOS.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Mac.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder__dbg_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Full.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__1_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__2_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__dbg__1_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__dbg__2_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__dbg__3_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS__Clang_dbg_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__32_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg__32_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_git_LinuxGit.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_git_LinuxGit_x64.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_git_MacGit.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_git_WinGit.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_git_WinGitXP.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg__32_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Clang__dbg_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Sync.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__1_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__1__32_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__2_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__2__32_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Sync.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Tests__1_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Tests__2_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Tests__3_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_7_Tests__1_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_7_Tests__2_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_7_Tests__3_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__1_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__2_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__3_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__4_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__1_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__2_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__3_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__4_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder__dbg_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Interactive_Tests__dbg_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_NaCl_Tests__x86_32_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_NaCl_Tests__x86_64_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Vista_Tests__1_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Vista_Tests__2_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Vista_Tests__3_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Sync.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Sync_x64.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__1_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__2_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__3_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__1_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__2_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__3_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__4_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__5_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__6_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_Aura.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__1_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__2_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__3_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder__dbg_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_XP_Tests__1_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_XP_Tests__2_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_XP_Tests__3_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_android_chromium_gn_compile_dbg.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_android_chromium_gn_compile_rel.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_linux_Android_GN.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_linux_Android_GN__dbg_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_linux_Linux_GN.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_linux_Linux_GN__dbg_.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_linux_chromium_gn_dbg.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_linux_chromium_gn_rel.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/unittest_android_dbg_trybot_success.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/unittest_linux_rel_success.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/unittest_revert_fails.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/unittest_second_sync_fails.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/unittest_sync_fails.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure_linux.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure_linux_bot_update.json View 1 3 chunks +6 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_first_failure_linux.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/deapply_compile_failure_linux.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_chromeos_clang_dbg.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_chromeos_clang_rel.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_chromeos_dbg.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_chromeos_rel.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_clang_dbg.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_clang_rel.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_compile_dbg.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_compile_rel.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_dbg.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_rel.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_trusty32_dbg.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_trusty32_rel.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_trusty_dbg.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_trusty_rel.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_rel_alt.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_chromium_compile_dbg.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_chromium_compile_rel.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_chromium_dbg.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_chromium_rel.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_compile_dbg.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_compile_rel.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_dbg.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_rel.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_x64_dbg.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_x64_rel.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gclient_revert_failure.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gclient_revert_failure_linux.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gclient_revert_failure_win.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gclient_revert_nuke.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks_failure.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks_failure_bot_update.json View 1 2 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gclient_sync_no_data.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/invalid_json_without_patch.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/linux_rel_alt.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/persistent_failure_and_runhooks_2_fail_test.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/persistent_failure_and_runhooks_2_fail_test_bot_update.json View 1 2 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/blink.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/chromium.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/gclient_retry.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/tools_build.json View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
iannucci
6 years, 7 months ago (2014-05-09 19:08:21 UTC) #1
Ryan Tseng
https://codereview.chromium.org/278943002/diff/20001/scripts/slave/bot_update.py File scripts/slave/bot_update.py (right): https://codereview.chromium.org/278943002/diff/20001/scripts/slave/bot_update.py#newcode1015 scripts/slave/bot_update.py:1015: opts, args = parse.parse_args() nit: options? for consistency below. ...
6 years, 7 months ago (2014-05-09 21:33:20 UTC) #2
Ryan Tseng
(questions were answered offline) lgtm % nit looks like rietveld choked on a couple of ...
6 years, 7 months ago (2014-05-09 21:51:25 UTC) #3
iannucci
re-uploaded https://chromiumcodereview.appspot.com/278943002/diff/20001/scripts/slave/bot_update.py File scripts/slave/bot_update.py (right): https://chromiumcodereview.appspot.com/278943002/diff/20001/scripts/slave/bot_update.py#newcode1015 scripts/slave/bot_update.py:1015: opts, args = parse.parse_args() On 2014/05/09 21:33:21, Ryan ...
6 years, 7 months ago (2014-05-09 22:11:51 UTC) #4
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 7 months ago (2014-05-09 22:13:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/278943002/40001
6 years, 7 months ago (2014-05-09 22:14:19 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 22:15:52 UTC) #7
commit-bot: I haz the power
Presubmit check for 278943002-40001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 7 months ago (2014-05-09 22:15:52 UTC) #8
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 7 months ago (2014-05-09 22:16:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/278943002/60001
6 years, 7 months ago (2014-05-09 22:18:04 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 22:20:58 UTC) #11
Message was sent while issue was closed. 
Change committed as 269436

Powered by Google App Engine
This is Rietveld 408576698