Remove an unused QuicStreamFactory::Job constructor

net/quic/chromium/quic_stream_factory.cc

Index: net/quic/chromium/quic_stream_factory.cc
diff --git a/net/quic/chromium/quic_stream_factory.cc b/net/quic/chromium/quic_stream_factory.cc
index 88650c7bd7971796e2041e768ad86720bc51cca0..e7d2e7befa35c0948eb68324bfc5f11cc3d1f20d 100644
--- a/net/quic/chromium/quic_stream_factory.cc
+++ b/net/quic/chromium/quic_stream_factory.cc
@@ -286,12 +286,12 @@ class QuicStreamFactory::CertVerifierJob {
   const QuicServerId& server_id() const { return server_id_; }
 
  private:
-  QuicServerId server_id_;
+  const QuicServerId server_id_;
   ProofVerifierCallbackImpl* verify_callback_;
   std::unique_ptr<ProofVerifyContext> verify_context_;
   std::unique_ptr<ProofVerifyDetails> verify_details_;
   std::string verify_error_details_;
-  base::TimeTicks start_time_;
+  const base::TimeTicks start_time_;
   const NetLogWithSource net_log_;
   CompletionCallback callback_;
   base::WeakPtrFactory<CertVerifierJob> weak_factory_;
@@ -359,9 +359,9 @@ class QuicStreamFactory::Job {
   QuicStreamFactory* factory_;
   HostResolver* host_resolver_;
   std::unique_ptr<HostResolver::Request> request_;
-  QuicSessionKey key_;
-  int cert_verify_flags_;
-  bool was_alternative_service_recently_broken_;
+  const QuicSessionKey key_;
+  const int cert_verify_flags_;
+  const bool was_alternative_service_recently_broken_;
   std::unique_ptr<QuicServerInfo> server_info_;
   bool started_another_job_;
   const NetLogWithSource net_log_;
@@ -396,22 +396,6 @@ QuicStreamFactory::Job::Job(QuicStreamFactory* factory,
       session_(nullptr),
       weak_factory_(this) {}
 
-QuicStreamFactory::Job::Job(QuicStreamFactory* factory,
-                            HostResolver* host_resolver,
-                            QuicChromiumClientSession* session,
-                            const QuicSessionKey& key)
-    : io_state_(STATE_RESUME_CONNECT),
-      factory_(factory),
-      host_resolver_(host_resolver),  // unused
-      key_(key),
-      cert_verify_flags_(0),                            // unused
-      was_alternative_service_recently_broken_(false),  // unused
-      started_another_job_(false),                      // unused
-      net_log_(session->net_log()),                     // unused
-      num_sent_client_hellos_(0),
-      session_(session),
-      weak_factory_(this) {}

[Zhongyi Shi, 2017/04/05 00:00:29]

Tracing the history of this code, this Job was used when we tried resume
connection if the 0RTT handshake had timed out. We don't have that logic anymore
in the current world. You might want to remove the code for RESUME_CONNECT as
well. 

https://codereview.chromium.org/318993004/

[Ryan Hamilton, 2017/04/05 00:10:10]

Nice catch, both of you. I agree with this suggestion.

[xunjieli, 2017/04/05 15:07:29]

Done. Good catch! The tests added in that CL are all passing, so I didn't touch
them. PTAL.

-
 QuicStreamFactory::Job::~Job() {
   DCHECK(callback_.is_null());