Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1839)

Unified Diff: chrome/browser/ui/webui/sync_setup_browsertest.js

Issue 2789233002: Disable SyncSetupWebUITestAsync.VerifySignIn, now also on MacOS X (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_setup_browsertest.js
diff --git a/chrome/browser/ui/webui/sync_setup_browsertest.js b/chrome/browser/ui/webui/sync_setup_browsertest.js
index a9d429a651055c7021baee2eb977d43f0b2d47c5..b3654ce11f4569472307af3faed4417767c0c88d 100644
--- a/chrome/browser/ui/webui/sync_setup_browsertest.js
+++ b/chrome/browser/ui/webui/sync_setup_browsertest.js
@@ -81,14 +81,9 @@ SyncSetupWebUITestAsync.prototype = {
},
};
-// This test is flaky on Linux bot (crbug.com/579666) and Windows bot
+// This test is flaky on Linux bot (crbug.com/579666) and Windows & Mac bots
// (crbug.com/608975).
-GEN('#if defined(OS_LINUX) || defined(OS_WIN)');
-GEN('#define MAYBE_VerifySignIn DISABLED_VerifySignIn');
-GEN('#else');
-GEN('#define MAYBE_VerifySignIn VerifySignIn');
-GEN('#endif // defined(OS_LINUX) || defined(OS_WIN)');
-TEST_F('SyncSetupWebUITestAsync', 'MAYBE_VerifySignIn', function() {
+TEST_F('SyncSetupWebUITestAsync', 'DISABLED_VerifySignIn', function() {
// Handle SyncSetupStartSignIn by displaying the sync setup dialog, verifying
// that a confirmation dialog appears, and clicking OK to dismiss the dialog.
// Note that this test doesn't actually do a gaia sign in.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698