Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: chrome/browser/ui/toolbar/app_menu_icon_controller.cc

Issue 2789203003: [Views] App Menu Animated Icon (Closed)
Patch Set: nit Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/views/toolbar/app_menu_animation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/app_menu_icon_controller.cc
diff --git a/chrome/browser/ui/toolbar/app_menu_icon_controller.cc b/chrome/browser/ui/toolbar/app_menu_icon_controller.cc
index 94409738ee8860f9b759e78c599e8d1d9cf8329e..2d67da24e355e5f67395964cead480273f40ff08 100644
--- a/chrome/browser/ui/toolbar/app_menu_icon_controller.cc
+++ b/chrome/browser/ui/toolbar/app_menu_icon_controller.cc
@@ -40,14 +40,7 @@ AppMenuIconController::Severity SeverityFromUpgradeLevel(
// Checks if the app menu icon should be animated for the given upgrade level.
bool ShouldAnimateUpgradeLevel(
UpgradeDetector::UpgradeNotificationAnnoyanceLevel level) {
- bool should_animate = true;
- if (level == UpgradeDetector::UPGRADE_ANNOYANCE_LOW) {
- // Only animate low severity upgrades once.
- static bool should_animate_low_severity = true;
- should_animate = should_animate_low_severity;
- should_animate_low_severity = false;
- }
- return should_animate;
+ return level != UpgradeDetector::UPGRADE_ANNOYANCE_NONE;
}
// Returns true if we should show the upgrade recommended icon.
@@ -121,8 +114,7 @@ void AppMenuIconController::UpdateDelegate() {
return;
}
- delegate_->UpdateSeverity(IconType::NONE,
- Severity::NONE, true);
+ delegate_->UpdateSeverity(IconType::NONE, Severity::NONE, false);
}
#if defined(OS_WIN)
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/views/toolbar/app_menu_animation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698