Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: chrome/browser/about_flags.cc

Issue 2789203003: [Views] App Menu Animated Icon (Closed)
Patch Set: nit Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index aa20d19c26515fc3eea870732d608bffee6ca69e..20b1ee51ead92bd8f4b7f2ed48aea0b9fa8bf203 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -539,6 +539,20 @@ const FeatureEntry::Choice kAshForceTabletModeChoices[] = {
};
#endif // OS_CHROMEOS
+#if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) || \
+ defined(OS_WIN)
+const FeatureEntry::Choice kAppMenuIconChoices[] = {
+ {flags_ui::kGenericExperimentChoiceDefault, "", ""},
+ {flag_descriptions::kAppMenuIconOldBehavior, switches::kAppMenuIcon,
+ switches::kAppMenuIconOldBehavior},
+ {flag_descriptions::kAppMenuIconPersistentOpenedState,
+ switches::kAppMenuIcon, switches::kAppMenuIconPersistentOpenedState},
+ {flag_descriptions::kAppMenuIconPersistentClosedState,
+ switches::kAppMenuIcon, switches::kAppMenuIconPersistentClosedState},
+};
+#endif // defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) ||
+ // defined(OS_WIN)
+
#if defined(OS_ANDROID)
const FeatureEntry::FeatureParam
kContentSuggestionsCategoryOrderFeatureVariationGeneral[] = {
@@ -2558,6 +2572,9 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kOmniboxEntitySuggestionsName,
flag_descriptions::kOmniboxEntitySuggestionsDescription, kOsDesktop,
FEATURE_VALUE_TYPE(omnibox::kOmniboxEntitySuggestions)},
+ {"app-menu-icon", flag_descriptions::kAppMenuIconName,
+ flag_descriptions::kAppMenuIconDescription, kOsDesktop,
+ MULTI_VALUE_TYPE(kAppMenuIconChoices)},
#endif // defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) ||
// defined(OS_WIN)
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698