[Views] App Menu Animated Icon

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 521 matching lines @@
      ash::switches::kAshForceTabletModeTouchView},
     {flag_descriptions::kForceTabletModeClamshell,
      ash::switches::kAshForceTabletMode,
      ash::switches::kAshForceTabletModeClamshell},
     {flag_descriptions::kForceTabletModeAuto,
      ash::switches::kAshForceTabletMode,
      ash::switches::kAshForceTabletModeAuto},
 };
 #endif  // OS_CHROMEOS
 
+#if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) || \
+    defined(OS_WIN)
+const FeatureEntry::Choice kGlobalErrorMenuIconChoices[] = {

[msw, 2017/04/13 17:23:12]

nit: It's a bit odd to use the GlobalError name throughout these flags, since it
seems like the global error icon is a different thing (IconType::GLOBAL_ERROR
vs. IconType::UPGRADE_NOTIFICATION). It doesn't matter too much since this is a
temporary flag for experimentation, but maybe consider renaming these something
like AppMenuAnimation/UpgradeAnimation/UpdateAnimation/AppIconAnimation?

[spqchan, 2017/04/13 22:52:42]

Done.

+    {flags_ui::kGenericExperimentChoiceDefault, "", ""},
+    {flag_descriptions::kGlobalErrorMenuIconOldBehavior,
+     switches::kGlobalErrorMenuIcon, switches::kGlobalErrorMenuIconOldBehavior},
+    {flag_descriptions::kGlobalErrorMenuIconPersistentOpenedState,
+     switches::kGlobalErrorMenuIcon,
+     switches::kGlobalErrorMenuIconPersistentOpenedState},
+    {flag_descriptions::kGlobalErrorMenuIconPersistentClosedState,
+     switches::kGlobalErrorMenuIcon,
+     switches::kGlobalErrorMenuIconPersistentClosedState},
+};
+#endif  // defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) ||
+        // defined(OS_WIN)
+
 #if defined(OS_ANDROID)
 const FeatureEntry::FeatureParam
     kContentSuggestionsCategoryOrderFeatureVariationGeneral[] = {
         {ntp_snippets::kCategoryOrderParameter,
          ntp_snippets::kCategoryOrderGeneral},
 };
 
 const FeatureEntry::FeatureParam
     kContentSuggestionsCategoryOrderFeatureVariationEMOriented[] = {
         {ntp_snippets::kCategoryOrderParameter,
@@ skipping 1999 matching lines @@
     {"new-omnibox-answer-types", flag_descriptions::kNewOmniboxAnswerTypesName,
      flag_descriptions::kNewOmniboxAnswerTypesDescription, kOsAll,
      FEATURE_VALUE_TYPE(omnibox::kNewOmniboxAnswerTypes)},
 
 #if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) || \
     defined(OS_WIN)
     {"omnibox-entity-suggestions",
      flag_descriptions::kOmniboxEntitySuggestionsName,
      flag_descriptions::kOmniboxEntitySuggestionsDescription, kOsDesktop,
      FEATURE_VALUE_TYPE(omnibox::kOmniboxEntitySuggestions)},
+    {"global-error-menu-icon", flag_descriptions::kGlobalErrorMenuIconName,
+     flag_descriptions::kGlobalErrorMenuIconDescription, kOsDesktop,
+     MULTI_VALUE_TYPE(kGlobalErrorMenuIconChoices)},
 #endif  // defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) ||
         // defined(OS_WIN)
 
 #if defined(OS_ANDROID)
     {"enable-custom-feedback-ui",
      flag_descriptions::kEnableCustomFeedbackUiName,
      flag_descriptions::kEnableCustomFeedbackUiDescription, kOsAndroid,
      FEATURE_VALUE_TYPE(chrome::android::kCustomFeedbackUi)},
 #endif  // OS_ANDROID
 
@@ skipping 280 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags