[Views] App Menu Animated Icon

chrome/browser/ui/views/toolbar/app_menu_animation.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_APP_MENU_ANIMATION_H_
+#define CHROME_BROWSER_UI_VIEWS_TOOLBAR_APP_MENU_ANIMATION_H_
+
+#include "third_party/skia/include/core/SkColor.h"
+#include "ui/gfx/animation/animation_delegate.h"
+#include "ui/gfx/animation/slide_animation.h"

[sky, 2017/04/11 20:52:00]

Generally we use unique_ptr and forward declare members (see chromium style
guide for specifics).

[spqchan, 2017/04/12 19:42:10]

Done.

+
+namespace gfx {
+class Canvas;
+class PointF;
+}  // namespace gfx
+
+class AppMenuButton;
+
+// This class is used for animating and drawing the app menu icon.
+class AppMenuAnimation : public gfx::AnimationDelegate {
+ public:
+  AppMenuAnimation(AppMenuButton* owner, bool should_animation_close);

[sky, 2017/04/11 20:52:00]

I suggest changing AppMenuButton to View* as the only thing you need is called
SchedulePaint, which is in View.

[spqchan, 2017/04/12 19:42:10]

Done.

+
+  // Paints the app menu icon.
+  void PaintAppMenu(gfx::Canvas* canvas, const gfx::Rect& bounds);
+
+  // Updates the icon colors.
+  void UpdateIconColor(SkColor start_color, SkColor severity_color);

[sky, 2017/04/11 20:52:00]

SetIconColors?

[spqchan, 2017/04/12 19:42:10]

Done.

+
+  // Starts the animation if it's not already running.
+  void StartAnimation();
+
+  // gfx::AnimationDelegate:
+  void AnimationEnded(const gfx::Animation* animation) override;
+  void AnimationProgressed(const gfx::Animation* animation) override;
+
+ private:
+  // This class is used to represent and paint a dot on the app menu.
+  class AppMenuDot {
+   public:
+    AppMenuDot(float delay,
+               float width_open_interval,
+               float stroke_open_interval);
+    void Paint(gfx::PointF center_pt,
+               SkColor start_color,
+               SkColor final_color,
+               gfx::Canvas* canvas,
+               const gfx::Rect& bounds,
+               gfx::SlideAnimation* animation);
+
+   private:
+    // The delay before the dot starts animating in ms.
+    float delay_;

[sky, 2017/04/11 20:52:00]

const where possible.

[spqchan, 2017/04/12 19:42:10]

Done.

+
+    // The percentage of time it takes for each dot to animate to its width
+    // and stroke in its open state.
+    float width_open_interval_;
+    float stroke_open_interval_;
+  };

[sky, 2017/04/11 20:52:00]

DISALLOW...

[spqchan, 2017/04/12 19:42:10]

Done.

+
+  AppMenuButton* owner_;  // weak.
+
+  // True if the animation should close after it finishes opening.
+  bool should_animation_close_;

[sky, 2017/04/11 20:52:00]

should_animate_closed_?

[spqchan, 2017/04/12 19:42:10]

Done.

+
+  gfx::SlideAnimation animation_;
+
+  AppMenuDot bottom_dot_;
+  AppMenuDot middle_dot_;
+  AppMenuDot top_dot_;
+
+  // The starting color of the dots. The animation is expected to transition
+  // from this color to |severity_color_|.
+  SkColor start_color_;
+
+  // The severity color of the dots. This is final color at the end of the
+  // animation.
+  SkColor severity_color_;
+};

[sky, 2017/04/11 20:52:00]

DISALLOW...

[spqchan, 2017/04/12 19:42:10]

Done.

+
+#endif  // CHROME_BROWSER_UI_VIEWS_TOOLBAR_APP_MENU_ANIMATION_H_