Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 2789113005: Fix for resynthesis when a part URI is empty. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for resynthesis when a part URI is empty. This is about 20% of all internal exceptions. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/83f6ef67a8b6d1a5cebd776d7802aeb654156e59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 8 months ago (2017-04-04 17:45:36 UTC) #1
Paul Berry
lgtm
3 years, 8 months ago (2017-04-04 17:59:21 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 83f6ef67a8b6d1a5cebd776d7802aeb654156e59 (presubmit successful).
3 years, 8 months ago (2017-04-04 19:31:57 UTC) #4
Brian Wilkerson
3 years, 8 months ago (2017-04-04 19:50:43 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698