Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2789093003: Mark QUIC broken when the network blackholes after the handshake (Closed)
Patch Set: Rename mark_quic_broken_when_network_suspected to mark_quic_broken_when_network_blackholes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_session_configurator/network_session_configurator_unittest.cc
diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc
index 0c4e95d84ddbb717067de560d9e1522b8185966d..f4dcd1075f02b0492b60a12eb833df1bb835f38d 100644
--- a/components/network_session_configurator/network_session_configurator_unittest.cc
+++ b/components/network_session_configurator/network_session_configurator_unittest.cc
@@ -67,6 +67,7 @@ TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) {
ParseFieldTrials();
EXPECT_TRUE(params_.enable_quic);
+ EXPECT_FALSE(params_.mark_quic_broken_when_network_blackholes);
EXPECT_EQ(1350u, params_.quic_max_packet_length);
EXPECT_EQ(net::QuicTagVector(), params_.quic_connection_options);
EXPECT_FALSE(params_.quic_always_require_handshake_confirmation);
@@ -121,6 +122,18 @@ TEST_F(NetworkSessionConfiguratorTest, EnableQuicForDataReductionProxy) {
}
TEST_F(NetworkSessionConfiguratorTest,
+ MarkQuicBrokenWhenNetworkBlackholesFromFieldTrialParams) {
+ std::map<std::string, std::string> field_trial_params;
+ field_trial_params["mark_quic_broken_when_network_blackholes"] = "true";
+ variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
+ base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
+
+ ParseFieldTrials();
+
+ EXPECT_TRUE(params_.mark_quic_broken_when_network_blackholes);
+}
+
+TEST_F(NetworkSessionConfiguratorTest,
QuicCloseSessionsOnIpChangeFromFieldTrialParams) {
std::map<std::string, std::string> field_trial_params;
field_trial_params["close_sessions_on_ip_change"] = "true";

Powered by Google App Engine
This is Rietveld 408576698