chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java - Issue 2789083002: Properly clean up notification on download open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java

Issue 2789083002: Properly clean up notification on download open (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java

index 0cc636550d15b81f04e4de6b198d59e481db1b1d..557446fe9b7b1e833befe5715f6df4337ca297f0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java

@@ -55,6 +55,13 @@ public interface DownloadNotifier {

void notifyDownloadCanceled(String downloadGuid);

/**

+ * Remove the download notification for an already finished download.

+ * @param notificationId The id of the download notification.

+ * @param downloadInfo Info about the removed download.

+ */

+ void removeDownloadNotification(int notificationId, DownloadInfo downloadInfo);

+ /**

* Called to resume all the pending download entries in SharedPreferences.

void resumePendingDownloads();