Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: runtime/observatory/tests/service/async_single_step_exception_test.dart

Issue 2788993002: Fix test failure and add new awaiterFrames to service_dev.md (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/service/service_dev.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/async_single_step_exception_test.dart
diff --git a/runtime/observatory/tests/service/async_single_step_exception_test.dart b/runtime/observatory/tests/service/async_single_step_exception_test.dart
index 06b0027e557bfae583a9c0d55766e2e27c448649..365aab7ae9081e77a1a386f03e27e982fe8504d7 100644
--- a/runtime/observatory/tests/service/async_single_step_exception_test.dart
+++ b/runtime/observatory/tests/service/async_single_step_exception_test.dart
@@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE file.
// VMOptions=--error_on_bad_type --error_on_bad_override --verbose_debug
+import 'dart:async';
import 'dart:developer';
import 'package:observatory/models.dart' as M;
import 'package:observatory/service_io.dart';
@@ -10,17 +11,18 @@ import 'package:unittest/unittest.dart';
import 'service_test_common.dart';
import 'test_helper.dart';
-const LINE_A = 20;
-const LINE_B = 21;
-const LINE_C = 26;
-const LINE_D = 27;
-const LINE_E = 28;
-const LINE_F = 35;
-const LINE_G = 38;
+const LINE_A = 23;
+const LINE_B = 24;
+const LINE_C = 30;
+const LINE_D = 32;
+const LINE_E = 35;
+const LINE_F = 38;
+const LINE_G = 40;
helper() async {
print('helper'); // LINE_A.
throw 'a'; // LINE_B.
+ return null;
}
testMain() async {
@@ -52,9 +54,15 @@ var tests = [
stoppedAtLine(LINE_B), // throw 'a'.
stepInto, // exit helper via a throw.
hasStoppedAtBreakpoint,
+ stepInto, // exit helper via a throw.
+ hasStoppedAtBreakpoint,
+ stepInto, // step once from entry to main.
+ hasStoppedAtBreakpoint,
stoppedAtLine(LINE_E), // print(error)
stepOver,
hasStoppedAtBreakpoint,
+ stepOver,
+ hasStoppedAtBreakpoint,
stoppedAtLine(LINE_F), // print(foo)
stepOver,
hasStoppedAtBreakpoint,
« no previous file with comments | « no previous file | runtime/vm/service/service_dev.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698