Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2788933002: Fix ignore on FutureOr (Closed)

Created:
3 years, 8 months ago by vsm
Modified:
3 years, 8 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org, srawlins, keertip
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix ignore on FutureOr I'll look into adding tests - these eventually supposed to *not* get ignored (see #27223) R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/08f085727ec61d3546219e05da7e1a6ca73f68a7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo #

Patch Set 3 : Reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 2 Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vsm
3 years, 8 months ago (2017-03-31 16:17:18 UTC) #3
Leaf
typo on $type, otherwise lgtm https://codereview.chromium.org/2788933002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart (right): https://codereview.chromium.org/2788933002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart#newcode473 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:473: if ($_isFutureOr($type)) { I ...
3 years, 8 months ago (2017-03-31 16:21:45 UTC) #4
vsm
https://codereview.chromium.org/2788933002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart (right): https://codereview.chromium.org/2788933002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart#newcode473 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:473: if ($_isFutureOr($type)) { On 2017/03/31 16:21:45, Leaf wrote: > ...
3 years, 8 months ago (2017-03-31 16:24:57 UTC) #5
vsm
3 years, 8 months ago (2017-03-31 16:30:35 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:20001) manually as
08f085727ec61d3546219e05da7e1a6ca73f68a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698