Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 278893002: Add a dry-run option to gyp_skia. (Closed)

Created:
6 years, 7 months ago by bungeman-skia
Modified:
6 years, 7 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add a dry-run option to gyp_skia. There are times when I want to do some low-level fiddling with the gyp command. It's nice to start with whatever the 'default' is, and it's also nice to peek behind the curtain to see what's going on. To this end, a '--dry-run' in the argument list will spit out the command to run, rather than running the command. R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=14674

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M gyp_skia View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
6 years, 7 months ago (2014-05-09 14:39:58 UTC) #1
epoger
lgtm
6 years, 7 months ago (2014-05-09 14:50:16 UTC) #2
bungeman-skia
6 years, 7 months ago (2014-05-09 15:04:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698