Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2788923002: Add assertion on addImplementationBuilder. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 3 chunks +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
ahe
3 years, 8 months ago (2017-03-31 15:31:23 UTC) #2
karlklose
LGTM https://codereview.chromium.org/2788923002/diff/1/pkg/front_end/lib/src/fasta/source/source_library_builder.dart File pkg/front_end/lib/src/fasta/source/source_library_builder.dart (right): https://codereview.chromium.org/2788923002/diff/1/pkg/front_end/lib/src/fasta/source/source_library_builder.dart#newcode73 pkg/front_end/lib/src/fasta/source/source_library_builder.dart:73: bool canAddImplementationBuilders = false; Could you add a ...
3 years, 8 months ago (2017-04-03 06:48:14 UTC) #3
ahe
Thank you, Karl! https://codereview.chromium.org/2788923002/diff/1/pkg/front_end/lib/src/fasta/source/source_library_builder.dart File pkg/front_end/lib/src/fasta/source/source_library_builder.dart (right): https://codereview.chromium.org/2788923002/diff/1/pkg/front_end/lib/src/fasta/source/source_library_builder.dart#newcode73 pkg/front_end/lib/src/fasta/source/source_library_builder.dart:73: bool canAddImplementationBuilders = false; On 2017/04/03 ...
3 years, 8 months ago (2017-04-04 09:46:44 UTC) #4
ahe
3 years, 8 months ago (2017-04-04 13:43:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
368d1ec58af35f61938f62d2be81d310a6c4c430 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698