Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: chrome/browser/resources/settings/site_settings/category_default_setting.html

Issue 2788853003: [MD settings] clickable toggle labels on category default toggles (Closed)
Patch Set: restore separator line Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/site_settings/category_default_setting.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/category_default_setting.html
diff --git a/chrome/browser/resources/settings/site_settings/category_default_setting.html b/chrome/browser/resources/settings/site_settings/category_default_setting.html
index 19cb12a1d0497f630c4fabdad94e19128ab609ff..333f4eda3996353fcc48679ec6b06f7246445386 100644
--- a/chrome/browser/resources/settings/site_settings/category_default_setting.html
+++ b/chrome/browser/resources/settings/site_settings/category_default_setting.html
@@ -9,24 +9,18 @@
<dom-module id="category-default-setting">
<template>
<style include="settings-shared"></style>
- <div class="settings-box first">
- <settings-toggle-button id="toggle" pref="{{controlParams_}}"
- class="start" label="[[sliderDescription_]]"
- disabled$="[[isToggleDisabled_(category)]]">
- </settings-toggle-button>
- </div>
+ <settings-toggle-button id="toggle"
+ class="settings-box first"
+ pref="{{controlParams_}}" label="[[optionLabel_]]"
+ sub-label="[[optionDescription]]"
+ disabled$="[[isToggleDisabled_(category)]]">
+ </settings-toggle-button>
<template is="dom-if" if="[[subOptionLabel]]">
- <div class$="settings-box [[subOptionClass_(subOptionSecondary)]]">
- <div class="start">
- [[subOptionLabel]]
- <div class="secondary" hidden$="[[!subOptionSecondary]]">
- [[subOptionSecondary]]
- </div>
- </div>
- <settings-toggle-button disabled$="[[!controlParams_.value]]"
- id="subOptionToggle" pref="{{subControlParams_}}">
- </settings-toggle-button>
- </div>
+ <settings-toggle-button id="subOptionToggle"
+ class="settings-box" pref="{{subControlParams_}}"
+ label="[[subOptionLabel]]" sub-label="[[subOptionDescription]]"
+ disabled$="[[!controlParams_.value]]">
+ </settings-toggle-button>
</template>
</template>
<script src="category_default_setting.js"></script>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/site_settings/category_default_setting.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698