Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: chrome/browser/resources/settings/site_settings/category_default_setting.html

Issue 2788853003: [MD settings] clickable toggle labels on category default toggles (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> 2 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
3 <link rel="import" href="../controls/settings_toggle_button.html"> 3 <link rel="import" href="../controls/settings_toggle_button.html">
4 <link rel="import" href="../settings_shared_css.html"> 4 <link rel="import" href="../settings_shared_css.html">
5 <link rel="import" href="constants.html"> 5 <link rel="import" href="constants.html">
6 <link rel="import" href="site_settings_behavior.html"> 6 <link rel="import" href="site_settings_behavior.html">
7 <link rel="import" href="site_settings_prefs_browser_proxy.html"> 7 <link rel="import" href="site_settings_prefs_browser_proxy.html">
8 8
9 <dom-module id="category-default-setting"> 9 <dom-module id="category-default-setting">
10 <template> 10 <template>
11 <style include="settings-shared"></style> 11 <style include="settings-shared"></style>
12 <div class="settings-box first"> 12 <settings-toggle-button id="toggle"
13 <settings-toggle-button id="toggle" pref="{{controlParams_}}" 13 class="settings-box first"
stevenjb 2017/03/31 23:28:14 Interesting. I guess since settings-toggle-button
dschuyler 2017/04/01 00:09:38 It should be good. You're right, the whole row is
14 class="start" label="[[sliderDescription_]]" 14 pref="{{controlParams_}}" label="[[optionLabel_]]"
15 disabled$="[[isToggleDisabled_(category)]]"> 15 sub-label="[[optionDescription]]"
16 disabled$="[[isToggleDisabled_(category)]]">
stevenjb 2017/03/31 23:28:14 I forget, do we need to explicitly set a11y proper
dschuyler 2017/04/01 00:09:38 Iiuc, it's implicit, handled by settings_toggle_bu
17 </settings-toggle-button>
18 <template is="dom-if" if="[[subOptionLabel]]">
19 <settings-toggle-button id="subOptionToggle"
20 class="settings-box continuation"
21 pref="{{subControlParams_}}"
22 label="[[subOptionLabel]]" sub-label="[[subOptionDescription]]"
23 disabled$="[[!controlParams_.value]]">
16 </settings-toggle-button> 24 </settings-toggle-button>
17 </div>
18 <template is="dom-if" if="[[subOptionLabel]]">
19 <div class$="settings-box [[subOptionClass_(subOptionSecondary)]]">
20 <div class="start">
21 [[subOptionLabel]]
22 <div class="secondary" hidden$="[[!subOptionSecondary]]">
23 [[subOptionSecondary]]
24 </div>
25 </div>
26 <settings-toggle-button disabled$="[[!controlParams_.value]]"
27 id="subOptionToggle" pref="{{subControlParams_}}">
28 </settings-toggle-button>
29 </div>
30 </template> 25 </template>
31 </template> 26 </template>
32 <script src="category_default_setting.js"></script> 27 <script src="category_default_setting.js"></script>
33 </dom-module> 28 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698