Issue 2788833002: TraceWrapperMember crashes when used as a value type of HeapHashMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2788833002: TraceWrapperMember crashes when used as a value type of HeapHashMap

Created:
3 years, 8 months ago by kouhei (in TOK)

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

TraceWrapperMember crashes when used as a value type of HeapHashMap BUG=

Patch Set 1 #

Total comments: 1

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -4 lines)			Patch
	M	third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp	View		3 chunks	+41 lines, -4 lines	1 comment	Download

Messages

Total messages: 5 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kouhei (in TOK)

3 years, 8 months ago (2017-03-31 05:59:21 UTC) #5

https://codereview.chromium.org/2788833002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp
(right):

https://codereview.chromium.org/2788833002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp:74: for
(int i = 0; i < 10000; ++i) {
OK This was because HashMap key should never be 0.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages