Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: third_party/WebKit/Source/modules/webauth/WebAuthentication.h

Issue 2788823002: Add the Mojo implementation of authenticator.mojom's MakeCredential. (Closed)
Patch Set: Removed dispose method Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webauth/WebAuthentication.h
diff --git a/third_party/WebKit/Source/modules/webauth/WebAuthentication.h b/third_party/WebKit/Source/modules/webauth/WebAuthentication.h
index 2ffff0fea4c3722a589044fa2259c558f6c94c9f..21f92ea929d049180d4e0399b582434357a7b1f3 100644
--- a/third_party/WebKit/Source/modules/webauth/WebAuthentication.h
+++ b/third_party/WebKit/Source/modules/webauth/WebAuthentication.h
@@ -37,8 +37,6 @@ class WebAuthentication final
virtual ~WebAuthentication();
- void Dispose();
-
// WebAuthentication.idl
ScriptPromise makeCredential(ScriptState*,
const RelyingPartyAccount&,
@@ -49,24 +47,26 @@ class WebAuthentication final
const BufferSource&,
const AuthenticationAssertionOptions&);
- // ContextLifecycleObserver overrides.
- void ContextDestroyed(ExecutionContext*) override;
-
webauth::mojom::blink::Authenticator* authenticator() const {
return m_authenticator.get();
}
- void onMakeCredential(ScriptPromiseResolver*,
- Vector<webauth::mojom::blink::ScopedCredentialInfoPtr>);
- bool markRequestComplete(ScriptPromiseResolver*);
-
- void onAuthenticatorConnectionError();
+ // ContextLifecycleObserver overrides.
+ void ContextDestroyed(ExecutionContext*) override;
DECLARE_VIRTUAL_TRACE();
private:
explicit WebAuthentication(LocalFrame&);
+ void onMakeCredential(ScriptPromiseResolver*,
foolip 2017/05/12 07:55:50 Looks like this CL needs to be rebased to after th
+ webauth::mojom::blink::AuthenticatorStatus,
+ webauth::mojom::blink::ScopedCredentialInfoPtr);
+ ScriptPromise rejectIfNotSupported(ScriptState*);
+ void onAuthenticatorConnectionError();
+ bool markRequestComplete(ScriptPromiseResolver*);
+ void cleanup();
+
webauth::mojom::blink::AuthenticatorPtr m_authenticator;
HeapHashSet<Member<ScriptPromiseResolver>> m_authenticatorRequests;
};

Powered by Google App Engine
This is Rietveld 408576698