Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc

Issue 2788813002: Try to flush DOMStorage too when ending the browsing session.
Patch Set: fixes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include <list> 8 #include <list>
9 #include <memory> 9 #include <memory>
10 #include <set> 10 #include <set>
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 } 227 }
228 228
229 void ClearHttpAndMediaCaches( 229 void ClearHttpAndMediaCaches(
230 const base::Time begin, 230 const base::Time begin,
231 const base::Time end, 231 const base::Time end,
232 const base::Callback<bool(const GURL&)>& url_matcher, 232 const base::Callback<bool(const GURL&)>& url_matcher,
233 const base::Closure& callback) override { 233 const base::Closure& callback) override {
234 // Not needed in this test. 234 // Not needed in this test.
235 } 235 }
236 236
237 void Flush() override {} 237 std::vector<scoped_refptr<base::SequencedTaskRunner>> Flush() override {
238 return std::vector<scoped_refptr<base::SequencedTaskRunner>>();
239 }
238 240
239 void ClearBluetoothAllowedDevicesMapForTesting() override {} 241 void ClearBluetoothAllowedDevicesMapForTesting() override {}
240 242
241 StoragePartitionRemovalData GetStoragePartitionRemovalData() { 243 StoragePartitionRemovalData GetStoragePartitionRemovalData() {
242 return storage_partition_removal_data_; 244 return storage_partition_removal_data_;
243 } 245 }
244 246
245 private: 247 private:
246 void AsyncRunCallback(const base::Closure& callback) { 248 void AsyncRunCallback(const base::Closure& callback) {
247 callback.Run(); 249 callback.Run();
(...skipping 1458 matching lines...) Expand 10 before | Expand all | Expand 10 after
1706 1708
1707 EXPECT_TRUE(remover->is_removing()); 1709 EXPECT_TRUE(remover->is_removing());
1708 1710
1709 // Add one more deletion and wait for it. 1711 // Add one more deletion and wait for it.
1710 BlockUntilBrowsingDataRemoved( 1712 BlockUntilBrowsingDataRemoved(
1711 base::Time(), base::Time::Max(), BrowsingDataRemover::DATA_TYPE_COOKIES, 1713 base::Time(), base::Time::Max(), BrowsingDataRemover::DATA_TYPE_COOKIES,
1712 BrowsingDataRemover::ORIGIN_TYPE_UNPROTECTED_WEB); 1714 BrowsingDataRemover::ORIGIN_TYPE_UNPROTECTED_WEB);
1713 1715
1714 EXPECT_FALSE(remover->is_removing()); 1716 EXPECT_FALSE(remover->is_removing());
1715 } 1717 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698