Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html

Issue 2788803003: MD Settings: more consistently fix error message space for search engine (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html "> 1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html ">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">
5 <link rel="import" href="../i18n_setup.html"> 5 <link rel="import" href="../i18n_setup.html">
6 <link rel="import" href="search_engines_browser_proxy.html"> 6 <link rel="import" href="search_engines_browser_proxy.html">
7 7
8 <dom-module id="settings-search-engine-dialog"> 8 <dom-module id="settings-search-engine-dialog">
9 <template> 9 <template>
10 <style include="settings-shared"> 10 <style include="settings-shared">
11 :host { 11 :host {
12 --paper-input-container: { 12 --paper-input-container: {
13 /** 13 /**
14 * Prevent paper-input-container's default padding rule to eat up
15 * our padding-bottom rule.
16 */
17 padding: 8px 0;
dpapad 2017/03/31 01:22:18 Given the complication you discovered, would be it
scottchen 2017/03/31 20:35:33 Done.
18
19 /**
14 * Saves space for error message. Using calc to leave just enough 20 * Saves space for error message. Using calc to leave just enough
15 * space at all font sizes (default 0, grow/shrink with font-size). 21 * space at all font sizes (default 0, grow/shrink with font-size).
16 */ 22 */
17 padding-bottom: calc(1rem - 8px); 23 padding-bottom: calc(1rem - 8px);
18 }; 24 };
19 } 25 }
20 </style> 26 </style>
21 <dialog is="cr-dialog" id="dialog" close-text="$i18n{close}"> 27 <dialog is="cr-dialog" id="dialog" close-text="$i18n{close}">
22 <div class="title">[[dialogTitle_]]</div> 28 <div class="title">[[dialogTitle_]]</div>
23 <div class="body" on-keypress="onKeypress_"> 29 <div class="body" on-keypress="onKeypress_">
(...skipping 20 matching lines...) Expand all
44 $i18n{cancel}</paper-button> 50 $i18n{cancel}</paper-button>
45 <paper-button id="actionButton" class="action-button" 51 <paper-button id="actionButton" class="action-button"
46 on-tap="onActionButtonTap_"> 52 on-tap="onActionButtonTap_">
47 [[actionButtonText_]] 53 [[actionButtonText_]]
48 </paper-button> 54 </paper-button>
49 </div> 55 </div>
50 </dialog> 56 </dialog>
51 </template> 57 </template>
52 <script src="search_engine_dialog.js"></script> 58 <script src="search_engine_dialog.js"></script>
53 </dom-module> 59 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698