[Devtools] Added frame grouping to network panel

third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js

Index: third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js b/third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js
index c264d77c74023341d17753232b8edb1a0b8a1563..cc6ba991a18d7d7851e3236269e6dd29a3d71e39 100644
--- a/third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js
+++ b/third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js
@@ -11,8 +11,20 @@ NetworkGroupLookup.NetworkProductGroupLookup = class {
    * @param {!SDK.NetworkRequest} request
    * @return {?string}
    */
-  lookup(request) {
-    return ProductRegistry.nameForUrl(request.parsedURL);
+  groupKeyForRequest(request) {
+    var productName = ProductRegistry.nameForUrl(request.parsedURL);
+    if (!productName)
+      return null;
+    return productName;
+  }
+
+  /**
+   * @override
+   * @param {string} key
+   * @return {string}
+   */
+  groupNameForKey(key) {
+    return key;

[pfeldman, 2017/03/31 00:55:06]

And here you would need to cast it, which is fine.

[allada, 2017/04/03 17:40:52]

Done.

   }
 
   /**
@@ -21,7 +33,7 @@ NetworkGroupLookup.NetworkProductGroupLookup = class {
    * @return {string}
    */
   lookupColumnValue(request) {
-    return this.lookup(request) || '';
+    return ProductRegistry.nameForUrl(request.parsedURL) || '';
   }
 
   /**
@@ -38,3 +50,48 @@ NetworkGroupLookup.NetworkProductGroupLookup = class {
     return aValue > bValue ? 1 : -1;
   }
 };
+
+/**
+ * @implements {Network.NetworkGroupLookupInterface}
+ */
+NetworkGroupLookup.NetworkProductFrameGroupLookup = class {

[pfeldman, 2017/03/31 00:55:06]

It seems like closure gave up altogether compiling it. It should not have
compiled...

[allada, 2017/04/03 17:40:52]

Done.

+  /**
+   * @override
+   * @param {!SDK.NetworkRequest} request
+   * @return {?SDK.ResourceTreeFrame}
+   */
+  groupKeyForRequest(request) {
+    var resourceTreeModel = request.target().model(SDK.ResourceTreeModel);
+    if (!resourceTreeModel)
+      return null;
+    var frame = resourceTreeModel.frameForId(request.frameId);
+    if (!frame || frame.isMainFrame())
+      return null;
+    return frame;
+  }
+
+  /**
+   * @override
+   * @param {!SDK.ResourceTreeFrame} frame
+   * @return {string}
+   */
+  groupNameForKey(frame) {
+    var name;
+    var frameParsedURL = new Common.ParsedURL(frame.url);
+    if (frame.url)
+      name = ProductRegistry.nameForUrl(frameParsedURL);
+    if (name)
+      return name;
+    var stackTrace = frame.creationStackTrace();
+    while (stackTrace) {
+      for (var stack of stackTrace.callFrames) {
+        if (stack.url)
+          name = ProductRegistry.nameForUrl(new Common.ParsedURL(stack.url));

[pfeldman, 2017/03/31 00:55:06]

This is going to be expensive at some point. 1000 requests * 20 stack frames
each, we are now parsing 20K URLs on the page load -> stress. I'd suggest that
you introduce a local cache inside this lookup class instance that would at
least not do it over and over. I.e. url -> name map.

[allada, 2017/04/03 17:40:52]

Done.

+        if (name)
+          return name;
+      }
+      stackTrace = frame.parent;
+    }
+    return frameParsedURL.host || frame.name || '<iframe>';
+  }
+};