[Devtools] Added frame grouping to network panel

third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 335 matching lines @@
     if (request.endTime !== -1 && request.endTime < windowStart)
       return false;
     return true;
   }
 
   /**
    * @param {?Network.NetworkGroupLookupInterface} grouping
    */
   setGrouping(grouping) {
     this._activeGroupLookup = grouping;
+    this._nodeGroups.clear();
     this._invalidateAllItems();
   }
 
   /**
    * @param {!SDK.NetworkRequest} request
    * @return {?Network.NetworkRequestNode}
    */
   nodeForRequest(request) {
     return this._nodesByRequestId.get(request.requestId());
   }
@@ skipping 501 matching lines @@
   }
 
   /**
    * @param {!Network.NetworkRequestNode} node
    * @return {?Network.NetworkNode}
    */
   _parentNodeForInsert(node) {
     if (!this._activeGroupLookup)
       return this._dataGrid.rootNode();
 
-    var groupName = this._activeGroupLookup.lookup(node.request());
-    if (!groupName)
+    var groupKey = this._activeGroupLookup.groupKeyForRequest(node.request());
+    if (!groupKey)
       return this._dataGrid.rootNode();
 
-    var group = this._nodeGroups.get(groupName);
+    var group = this._nodeGroups.get(groupKey);
     if (group)
       return group;
-    group = new Network.NetworkGroupNode(this, groupName);
+    group = new Network.NetworkGroupNode(this, this._activeGroupLookup.groupNameForKey(groupKey));
     group.setColumnExtensions(this._columns.columnExtensions());
-    this._nodeGroups.set(groupName, group);
+    this._nodeGroups.set(groupKey, group);
     return group;
   }
 
   reset() {
     this._requestWithHighlightedInitiators = null;
     this.dispatchEventToListeners(Network.NetworkLogView.Events.RequestSelected, null);
 
     this._clearSearchMatchedList();
 
     this._setHoveredNode(null);
@@ skipping 898 matching lines @@
 
 /** @type {!Array<string>} */
 Network.NetworkLogView._searchKeys =
     Object.keys(Network.NetworkLogView.FilterType).map(key => Network.NetworkLogView.FilterType[key]);
 
 /** @typedef {function(!SDK.NetworkRequest): boolean} */
 Network.NetworkLogView.Filter;
 
 /**
  * @interface
+ * @template T
  */
 Network.NetworkGroupLookupInterface = function() {};
 
 Network.NetworkGroupLookupInterface.prototype = {
   /**
    * @param {!SDK.NetworkRequest} request
-   * @return {?string}
+   * @return {?T}

[pfeldman, 2017/03/31 00:55:06]

It can't be template, it should be an Object or "*" since it is interface (has
to be polymorphic).

[allada, 2017/04/03 17:40:52]

Done.

    */
-  lookup(request) {}
+  groupKeyForRequest(request) {},

[pfeldman, 2017/03/31 00:55:06]

Also, just say "groupForRequest"

[allada, 2017/04/03 17:40:52]

Done.

+
+  /**
+   * @param {!T} key
+   * @return {string}
+   */
+  groupNameForKey(key) {}
 };