add test for visibility detection

add test for visibility detection

getComputedStyle() in GWT only works for inline styles, not internal/external
stylesheets.  so add a test in browser instead.

BUG=367243
TBR=blundell

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271666

[kuan, 2014-05-14 16:52:40]

hi chris,

this test is dependent on https://codereview.chromium.org/275493007/ being
pulled into chrome, but ptal first.  thx.

[cjhopman, 2014-05-14 16:59:52]

https://codereview.chromium.org/278873003/diff/1/components/dom_distiller/con...
File components/dom_distiller/content/distiller_page_web_contents_browsertest.cc
(right):

https://codereview.chromium.org/278873003/diff/1/components/dom_distiller/con...
components/dom_distiller/content/distiller_page_web_contents_browsertest.cc:131:
Not(HasSubstr("I am not supposed to appear")));
This test needs to ensure that when those elements aren't hidden they do appear
in the output (i.e. it needs to confirm that they aren't in the input in the
current case *because* they are hidden).

[kuan, 2014-05-14 18:57:24]

i'm not sure if i understand correctly what u mean, but i tried to address ur
comment in patch set 2.  ptal.  thx.

https://codereview.chromium.org/278873003/diff/1/components/dom_distiller/con...
File components/dom_distiller/content/distiller_page_web_contents_browsertest.cc
(right):

https://codereview.chromium.org/278873003/diff/1/components/dom_distiller/con...
components/dom_distiller/content/distiller_page_web_contents_browsertest.cc:131:
Not(HasSubstr("I am not supposed to appear")));
On 2014/05/14 16:59:52, cjhopman wrote:
> This test needs to ensure that when those elements aren't hidden they do
appear
> in the output (i.e. it needs to confirm that they aren't in the input in the
> current case *because* they are hidden).

Done.  i'm not sure if this is what u meant.

[cjhopman, 2014-05-14 20:41:30]

On 2014/05/14 18:57:24, kuan wrote:
> i'm not sure if i understand correctly what u mean, but i tried to address ur
> comment in patch set 2.  ptal.  thx.
> 
>
https://codereview.chromium.org/278873003/diff/1/components/dom_distiller/con...
> File
components/dom_distiller/content/distiller_page_web_contents_browsertest.cc
> (right):
> 
>
https://codereview.chromium.org/278873003/diff/1/components/dom_distiller/con...
>
components/dom_distiller/content/distiller_page_web_contents_browsertest.cc:131:
> Not(HasSubstr("I am not supposed to appear")));
> On 2014/05/14 16:59:52, cjhopman wrote:
> > This test needs to ensure that when those elements aren't hidden they do
> appear
> > in the output (i.e. it needs to confirm that they aren't in the input in the
> > current case *because* they are hidden).
> 
> Done.  i'm not sure if this is what u meant.

This is better. It would be best to basically load two things that only differ
by one having invisibility the other not, and confirm that in one the invisible
stuff doesn't appear but in the other it does.

Also, these tests should use their own .html file and not modify
simple_article.html

[kuan, 2014-05-15 14:10:16]

i've addressed ur comments in patch set 3.  ptal.  thx.

[cjhopman, 2014-05-15 21:19:00]

lgtm

[kuan, 2014-05-20 09:30:00]

The CQ bit was checked by kuan@chromium.org

[commit-bot: I haz the power, 2014-05-20 09:30:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kuan@chromium.org/278873003/30001

[kuan, 2014-05-20 09:43:09]

The CQ bit was unchecked by kuan@chromium.org

[kuan, 2014-05-20 09:48:55]

tbr'ing blundell for new files in components/test/data/dom_distiller.

[kuan, 2014-05-20 09:49:19]

The CQ bit was checked by kuan@chromium.org

[commit-bot: I haz the power, 2014-05-20 09:49:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kuan@chromium.org/278873003/30001

[commit-bot: I haz the power, 2014-05-20 13:26:14]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-20 15:47:06]

Change committed as 271666