Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 278873002: Adjust cursor position to take multiple screens into consideration (Closed)

Created:
6 years, 7 months ago by robert.bradford
Modified:
6 years, 7 months ago
Reviewers:
miu
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@multi-display-2
Visibility:
Public.

Description

Adjust cursor position to take multiple screens into consideration The position returned from last_mouse_position() is in screen co-ordinates but the calculation steps for the composition expect that the cursor position be relative to the desktop dimentions. This change transforms the screen relative position into a position relative to the desktop window and hence relative to the secondary display. BUG=371761 TEST=Under ChromeOS capture a secondary screen and observe that the pointer is now composed into the video steam in the correct place Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/media/capture/desktop_capture_device_aura.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robert.bradford
6 years, 7 months ago (2014-05-09 14:01:14 UTC) #1
miu
lgtm
6 years, 7 months ago (2014-05-09 20:58:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.bradford@intel.com/278873002/1
6 years, 7 months ago (2014-05-09 21:03:51 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 23:09:53 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 00:27:55 UTC) #5
Message was sent while issue was closed.
Change committed as 269650

Powered by Google App Engine
This is Rietveld 408576698