Chromium Code Reviews| Index: third_party/leveldatabase/BUILD.gn |
| diff --git a/third_party/leveldatabase/BUILD.gn b/third_party/leveldatabase/BUILD.gn |
| index 49a609361912ce5407cec6a33c0fa3c9e3c0a524..46ff7d6959087c62ae86facdf2b62792b31baf54 100644 |
| --- a/third_party/leveldatabase/BUILD.gn |
| +++ b/third_party/leveldatabase/BUILD.gn |
| @@ -131,6 +131,8 @@ static_library("leveldatabase") { |
| ] |
| if (is_win) { |
| + # leveldb compiles with a limiterd set of warnings enabled, and is not |
|
cmumford
2017/03/30 18:15:32
typo.
pwnall
2017/03/30 20:38:34
Done.
Thank you very much for catching this!
|
| + # likely to accept fixes for other warnings. See crbug.com/698013 |
| cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison. |
| if (is_official_build) { |
| @@ -205,8 +207,6 @@ if (!is_ios && !is_android) { |
| ":leveldb_testutil", |
| ] |
| - # TODO(crbug.com/698013): Fix leveldb to remove the need for suppressing |
| - # warnings. |
| if (is_win) { |
| # util\cache_test.cc(167): warning C4018: '<': signed/unsigned mismatch |
| # util\cache_test.cc(171): warning C4018: '<': signed/unsigned mismatch |