Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: extensions/browser/sandboxed_unpacker_unittest.cc

Issue 2788563002: Transfer DictionaryValue ownership in SandboxedUnpacker::OnUnpackSuccess() (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/sandboxed_unpacker.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/sandboxed_unpacker_unittest.cc
diff --git a/extensions/browser/sandboxed_unpacker_unittest.cc b/extensions/browser/sandboxed_unpacker_unittest.cc
index e39f7b2fc4dd22617d7195459b4a56b9f80f263a..8330efa65af7ccc574ba5ea2ecdb8bc7e19d5d0d 100644
--- a/extensions/browser/sandboxed_unpacker_unittest.cc
+++ b/extensions/browser/sandboxed_unpacker_unittest.cc
@@ -45,7 +45,7 @@ class MockSandboxedUnpackerClient : public SandboxedUnpackerClient {
void OnUnpackSuccess(const base::FilePath& temp_dir,
const base::FilePath& extension_root,
- const base::DictionaryValue* original_manifest,
+ std::unique_ptr<base::DictionaryValue> original_manifest,
const Extension* extension,
const SkBitmap& install_icon) override {
temp_dir_ = temp_dir;
« no previous file with comments | « extensions/browser/sandboxed_unpacker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698