Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: extensions/browser/sandboxed_unpacker.h

Issue 2788563002: Transfer DictionaryValue ownership in SandboxedUnpacker::OnUnpackSuccess() (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/startup_helper.cc ('k') | extensions/browser/sandboxed_unpacker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/sandboxed_unpacker.h
diff --git a/extensions/browser/sandboxed_unpacker.h b/extensions/browser/sandboxed_unpacker.h
index 9007a47cbc3ff41996e81aaba7b17748e4d0b150..5b081df194529f223418b11ef554625d78d37477 100644
--- a/extensions/browser/sandboxed_unpacker.h
+++ b/extensions/browser/sandboxed_unpacker.h
@@ -51,11 +51,12 @@ class SandboxedUnpackerClient
// for deleting this memory.
//
// install_icon - The icon we will display in the installation UI, if any.
- virtual void OnUnpackSuccess(const base::FilePath& temp_dir,
- const base::FilePath& extension_root,
- const base::DictionaryValue* original_manifest,
- const Extension* extension,
- const SkBitmap& install_icon) = 0;
+ virtual void OnUnpackSuccess(
+ const base::FilePath& temp_dir,
+ const base::FilePath& extension_root,
+ std::unique_ptr<base::DictionaryValue> original_manifest,
+ const Extension* extension,
+ const SkBitmap& install_icon) = 0;
virtual void OnUnpackFailure(const CrxInstallError& error) = 0;
protected:
« no previous file with comments | « chrome/browser/extensions/startup_helper.cc ('k') | extensions/browser/sandboxed_unpacker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698