Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_app_data.cc

Issue 2788563002: Transfer DictionaryValue ownership in SandboxedUnpacker::OnUnpackSuccess() (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/app_mode/kiosk_external_update_validator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/app_mode/kiosk_app_data.cc
diff --git a/chrome/browser/chromeos/app_mode/kiosk_app_data.cc b/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
index 8522d7b3c7f8ee370ade36750c0e428428fba8ee..12b742c7e62e4af06826d503c0a69ebedf93baae 100644
--- a/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
+++ b/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
@@ -126,7 +126,7 @@ class KioskAppData::CrxLoader : public extensions::SandboxedUnpackerClient {
// extensions::SandboxedUnpackerClient
void OnUnpackSuccess(const base::FilePath& temp_dir,
const base::FilePath& extension_root,
- const base::DictionaryValue* original_manifest,
+ std::unique_ptr<base::DictionaryValue> original_manifest,
const extensions::Extension* extension,
const SkBitmap& install_icon) override {
DCHECK(task_runner_->RunsTasksOnCurrentThread());
« no previous file with comments | « no previous file | chrome/browser/chromeos/app_mode/kiosk_external_update_validator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698