Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: chrome/browser/chromeos/app_mode/kiosk_external_update_validator.h

Issue 2788563002: Transfer DictionaryValue ownership in SandboxedUnpacker::OnUnpackSuccess() (Closed)
Patch Set: address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_APP_MODE_KIOSK_EXTERNAL_UPDATE_VALIDATOR_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_APP_MODE_KIOSK_EXTERNAL_UPDATE_VALIDATOR_H_
6 #define CHROME_BROWSER_CHROMEOS_APP_MODE_KIOSK_EXTERNAL_UPDATE_VALIDATOR_H_ 6 #define CHROME_BROWSER_CHROMEOS_APP_MODE_KIOSK_EXTERNAL_UPDATE_VALIDATOR_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 // Starts validating the external crx file. 47 // Starts validating the external crx file.
48 void Start(); 48 void Start();
49 49
50 private: 50 private:
51 ~KioskExternalUpdateValidator() override; 51 ~KioskExternalUpdateValidator() override;
52 52
53 // SandboxedUnpackerClient overrides. 53 // SandboxedUnpackerClient overrides.
54 void OnUnpackFailure(const extensions::CrxInstallError& error) override; 54 void OnUnpackFailure(const extensions::CrxInstallError& error) override;
55 void OnUnpackSuccess(const base::FilePath& temp_dir, 55 void OnUnpackSuccess(const base::FilePath& temp_dir,
56 const base::FilePath& extension_dir, 56 const base::FilePath& extension_dir,
57 const base::DictionaryValue* original_manifest, 57 std::unique_ptr<base::DictionaryValue> original_manifest,
58 const extensions::Extension* extension, 58 const extensions::Extension* extension,
59 const SkBitmap& install_icon) override; 59 const SkBitmap& install_icon) override;
60 60
61 // Task runner for executing file I/O tasks. 61 // Task runner for executing file I/O tasks.
62 const scoped_refptr<base::SequencedTaskRunner> backend_task_runner_; 62 const scoped_refptr<base::SequencedTaskRunner> backend_task_runner_;
63 63
64 // Information about the external crx file. 64 // Information about the external crx file.
65 extensions::CRXFileInfo crx_file_; 65 extensions::CRXFileInfo crx_file_;
66 66
67 // The temporary directory used by SandBoxedUnpacker for unpacking extensions. 67 // The temporary directory used by SandBoxedUnpacker for unpacking extensions.
68 const base::FilePath crx_unpack_dir_; 68 const base::FilePath crx_unpack_dir_;
69 69
70 base::WeakPtr<KioskExternalUpdateValidatorDelegate> delegate_; 70 base::WeakPtr<KioskExternalUpdateValidatorDelegate> delegate_;
71 71
72 DISALLOW_COPY_AND_ASSIGN(KioskExternalUpdateValidator); 72 DISALLOW_COPY_AND_ASSIGN(KioskExternalUpdateValidator);
73 }; 73 };
74 74
75 } // namespace chromeos 75 } // namespace chromeos
76 76
77 #endif // CHROME_BROWSER_CHROMEOS_APP_MODE_KIOSK_EXTERNAL_UPDATE_VALIDATOR_H_ 77 #endif // CHROME_BROWSER_CHROMEOS_APP_MODE_KIOSK_EXTERNAL_UPDATE_VALIDATOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698