third_party/WebKit/Source/modules/accessibility/AXObject.cpp - Issue 2788523002: Finish all string attributes for Accessibility Object Model Phase 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Issue 2788523002: Finish all string attributes for Accessibility Object Model Phase 1. (Closed)

Patch Set: Test that checked works with true/false, not only 'true' and 'false' Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

index ace38e51f555c17a2f21657d599dc3c88ddebcbb..7e9354fdb0ee611492db16d93ba484783c7f5e24 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

@@ -952,7 +952,8 @@ AXSupportedAction AXObject::action() const {

}

AccessibilityButtonState AXObject::checkboxOrRadioValue() const {

- const AtomicString& checkedAttribute = getAttribute(aria_checkedAttr);

+ const AtomicString& checkedAttribute =

+ getAOMPropertyOrARIAAttribute(AOMStringProperty::kChecked);

if (equalIgnoringCase(checkedAttribute, "true"))

return ButtonStateOn;