Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: media/base/audio_buffer_converter.cc

Issue 2788483003: Introduce AudioBufferMemoryPool to avoid thrashing on audio buffers. (Closed)
Patch Set: Add class comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/audio_buffer_converter.h ('k') | media/base/audio_buffer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_buffer_converter.cc
diff --git a/media/base/audio_buffer_converter.cc b/media/base/audio_buffer_converter.cc
index ca59870a0a834183362b6ef4373125011b3b5ee8..e13df1d7bbf37d8c17cbf6c04d02e817090acb82 100644
--- a/media/base/audio_buffer_converter.cc
+++ b/media/base/audio_buffer_converter.cc
@@ -8,7 +8,6 @@
#include <cmath>
#include "base/logging.h"
-#include "media/base/audio_buffer.h"
#include "media/base/audio_bus.h"
#include "media/base/audio_decoder_config.h"
#include "media/base/audio_timestamp_helper.h"
@@ -34,7 +33,8 @@ AudioBufferConverter::AudioBufferConverter(const AudioParameters& output_params)
buffered_input_frames_(0.0),
io_sample_rate_ratio_(1.0),
timestamp_helper_(output_params_.sample_rate()),
- is_flushing_(false) {}
+ is_flushing_(false),
+ pool_(new AudioBufferMemoryPool()) {}
AudioBufferConverter::~AudioBufferConverter() {}
@@ -187,12 +187,10 @@ void AudioBufferConverter::ConvertIfPossible() {
if (!request_frames)
return;
- scoped_refptr<AudioBuffer> output_buffer =
- AudioBuffer::CreateBuffer(kSampleFormatPlanarF32,
- output_params_.channel_layout(),
- output_params_.channels(),
- output_params_.sample_rate(),
- request_frames);
+ scoped_refptr<AudioBuffer> output_buffer = AudioBuffer::CreateBuffer(
+ kSampleFormatPlanarF32, output_params_.channel_layout(),
+ output_params_.channels(), output_params_.sample_rate(), request_frames,
+ pool_);
std::unique_ptr<AudioBus> output_bus =
AudioBus::CreateWrapper(output_buffer->channel_count());
« no previous file with comments | « media/base/audio_buffer_converter.h ('k') | media/base/audio_buffer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698