Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: media/base/audio_buffer_converter.h

Issue 2788483003: Introduce AudioBufferMemoryPool to avoid thrashing on audio buffers. (Closed)
Patch Set: Add class comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/base/audio_buffer.cc ('k') | media/base/audio_buffer_converter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BASE_AUDIO_BUFFER_CONVERTER_H_ 5 #ifndef MEDIA_BASE_AUDIO_BUFFER_CONVERTER_H_
6 #define MEDIA_BASE_AUDIO_BUFFER_CONVERTER_H_ 6 #define MEDIA_BASE_AUDIO_BUFFER_CONVERTER_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <memory> 9 #include <memory>
10 10
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "base/time/time.h" 12 #include "base/time/time.h"
13 #include "media/base/audio_buffer.h"
13 #include "media/base/audio_converter.h" 14 #include "media/base/audio_converter.h"
14 #include "media/base/audio_parameters.h" 15 #include "media/base/audio_parameters.h"
15 #include "media/base/audio_timestamp_helper.h" 16 #include "media/base/audio_timestamp_helper.h"
16 #include "media/base/media_export.h" 17 #include "media/base/media_export.h"
17 18
18 namespace media { 19 namespace media {
19 20
20 class AudioBuffer;
21 class AudioBus; 21 class AudioBus;
22 22
23 // Takes AudioBuffers in any format and uses an AudioConverter to convert them 23 // Takes AudioBuffers in any format and uses an AudioConverter to convert them
24 // to a common format (usually the hardware output format). 24 // to a common format (usually the hardware output format).
25 class MEDIA_EXPORT AudioBufferConverter : public AudioConverter::InputCallback { 25 class MEDIA_EXPORT AudioBufferConverter : public AudioConverter::InputCallback {
26 public: 26 public:
27 explicit AudioBufferConverter(const AudioParameters& output_params); 27 explicit AudioBufferConverter(const AudioParameters& output_params);
28 ~AudioBufferConverter() override; 28 ~AudioBufferConverter() override;
29 29
30 void AddInput(const scoped_refptr<AudioBuffer>& buffer); 30 void AddInput(const scoped_refptr<AudioBuffer>& buffer);
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 // Ratio of sample rates, in/out. 91 // Ratio of sample rates, in/out.
92 double io_sample_rate_ratio_; 92 double io_sample_rate_ratio_;
93 93
94 // Computes timestamps in terms of the output sample rate. 94 // Computes timestamps in terms of the output sample rate.
95 AudioTimestampHelper timestamp_helper_; 95 AudioTimestampHelper timestamp_helper_;
96 96
97 // Are we flushing everything, without regard for providing AudioConverter 97 // Are we flushing everything, without regard for providing AudioConverter
98 // full AudioBuses in ProvideInput()? 98 // full AudioBuses in ProvideInput()?
99 bool is_flushing_; 99 bool is_flushing_;
100 100
101 // Pool to avoid thrashing memory when allocating AudioBuffers.
102 scoped_refptr<AudioBufferMemoryPool> pool_;
103
101 // The AudioConverter which does the real work here. 104 // The AudioConverter which does the real work here.
102 std::unique_ptr<AudioConverter> audio_converter_; 105 std::unique_ptr<AudioConverter> audio_converter_;
103 }; 106 };
104 107
105 } // namespace media 108 } // namespace media
106 109
107 #endif // MEDIA_BASE_AUDIO_BUFFER_CONVERTER_H_ 110 #endif // MEDIA_BASE_AUDIO_BUFFER_CONVERTER_H_
OLDNEW
« no previous file with comments | « media/base/audio_buffer.cc ('k') | media/base/audio_buffer_converter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698