Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc

Issue 2788473004: Disable SitePerProcessTextInputManagerTest.TrackStateWhenSwitchingFocusedFrames (Closed)
Patch Set: Add issue number Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/chrome_content_browser_client.h" 9 #include "chrome/browser/chrome_content_browser_client.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 private: 423 private:
424 DISALLOW_COPY_AND_ASSIGN(SitePerProcessTextInputManagerTest); 424 DISALLOW_COPY_AND_ASSIGN(SitePerProcessTextInputManagerTest);
425 }; 425 };
426 426
427 // The following test loads a page with multiple nested <iframe> elements which 427 // The following test loads a page with multiple nested <iframe> elements which
428 // are in or out of process with the main frame. Then an <input> field with 428 // are in or out of process with the main frame. Then an <input> field with
429 // unique value is added to every single frame on the frame tree. The test then 429 // unique value is added to every single frame on the frame tree. The test then
430 // creates a sequence of tab presses and verifies that after each key press, the 430 // creates a sequence of tab presses and verifies that after each key press, the
431 // TextInputState.value reflects that of the focused input, i.e., the 431 // TextInputState.value reflects that of the focused input, i.e., the
432 // TextInputManager is correctly tracking TextInputState across frames. 432 // TextInputManager is correctly tracking TextInputState across frames.
433 // flaky: crbug.com/704994
433 IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest, 434 IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
434 TrackStateWhenSwitchingFocusedFrames) { 435 DISABLED_TrackStateWhenSwitchingFocusedFrames) {
435 CreateIframePage("a(a,b,c(a,b,d(e, f)),g)"); 436 CreateIframePage("a(a,b,c(a,b,d(e, f)),g)");
436 std::vector<std::string> values{ 437 std::vector<std::string> values{
437 "main", "node_a", "node_b", "node_c", "node_c_a", 438 "main", "node_a", "node_b", "node_c", "node_c_a",
438 "node_c_b", "node_c_d", "node_c_d_e", "node_c_d_f", "node_g"}; 439 "node_c_b", "node_c_d", "node_c_d_e", "node_c_d_f", "node_g"};
439 440
440 // TODO(ekaramad): The use for explicitly constructing the IndexVector from 441 // TODO(ekaramad): The use for explicitly constructing the IndexVector from
441 // initializer list should not be necessary. However, some chromeos bots throw 442 // initializer list should not be necessary. However, some chromeos bots throw
442 // errors if we do not do it like this. 443 // errors if we do not do it like this.
443 std::vector<content::RenderFrameHost*> frames{ 444 std::vector<content::RenderFrameHost*> frames{
444 GetFrame(IndexVector{}), GetFrame(IndexVector{0}), 445 GetFrame(IndexVector{}), GetFrame(IndexVector{0}),
(...skipping 920 matching lines...) Expand 10 before | Expand all | Expand 10 after
1365 1366
1366 // Closing this WebContents while we still hold on to our TestBrowserClient. 1367 // Closing this WebContents while we still hold on to our TestBrowserClient.
1367 EXPECT_TRUE(browser()->tab_strip_model()->CloseWebContentsAt( 1368 EXPECT_TRUE(browser()->tab_strip_model()->CloseWebContentsAt(
1368 1, TabStripModel::CLOSE_USER_GESTURE)); 1369 1, TabStripModel::CLOSE_USER_GESTURE));
1369 1370
1370 // For the cleanup of the original WebContents in tab index 0. 1371 // For the cleanup of the original WebContents in tab index 0.
1371 content::SetBrowserClientForTesting(old_browser_client); 1372 content::SetBrowserClientForTesting(old_browser_client);
1372 } 1373 }
1373 #endif // defined(MAC_OSX) 1374 #endif // defined(MAC_OSX)
1374 #endif // !defined(OS_ANDROID) 1375 #endif // !defined(OS_ANDROID)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698