[regexp] Updates for unicode escapes in capture names

test/mjsunit/harmony/regexp-named-captures.js

 // Copyright 2017 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Flags: --harmony-regexp-named-captures --harmony-regexp-lookbehind
 
 // Malformed named captures.
 assertThrows("/(?<>a)/u", SyntaxError);  // Empty name.
 assertThrows("/(?<aa)/u", SyntaxError);  // Unterminated name.
 assertThrows("/(?<42a>a)/u", SyntaxError);  // Name starting with digits.
@@ skipping 165 matching lines @@
 // The '__proto__' property on the groups object.
 assertEquals(undefined, /(?<a>.)/u.exec("a").groups.__proto__);
 assertEquals("a", /(?<__proto__>a)/u.exec("a").groups.__proto__);
 
 // Backreference before the group (exercises the capture mini-parser).
 assertThrows("/\\1(?:.)/u", SyntaxError);
 assertThrows("/\\1(?<=a)./u", SyntaxError);
 assertThrows("/\\1(?<!a)./u", SyntaxError);
 assertEquals(["a", "a"], /\1(?<a>.)/u.exec("abcd"));
 
+// Unicode escapes in capture names.
+assertTrue(/(?<a\uD801\uDCA4>.)/u.test("a"));  // \u Lead \u Trail
+assertThrows("/(?<a\\uD801>.)/u", SyntaxError);  // \u Lead

[Yang, 2017/04/05 08:03:35]

Also test the case where you don't use the \u escape in the regexp pattern? I.e.
no double \\, like this "/(?<a\uD801>.)/u"

[jgruber, 2017/04/07 08:01:23]

You mean just a standard group name? "/(?<a\uD801>.)/u" is equivalent to
/(?<auD801>.)/u.

[jgruber, 2017/04/07 08:02:54]

Never mind, it's not. Will add a test.

+assertThrows("/(?<a\\uDCA4>.)/u", SyntaxError);  // \u Trail
+assertTrue(/(?<\u0041>.)/u.test("a"));  // \u NonSurrogate
+assertTrue(/(?<\u{0041}>.)/u.test("a"));  // \u{ Non-surrogate }
+assertTrue(/(?<a\u{104A4}>.)/u.test("a"));  // \u{ Surrogate, ID_Continue }
+assertThrows("/(?<a\\u{110000}>.)/u", SyntaxError);  // \u{ Out-of-bounds }
+
+assertThrows("/(?<a\\uD801\uDCA4>.)/", SyntaxError);
+assertThrows("/(?<a\\uD801>.)/", SyntaxError);
+assertThrows("/(?<a\\uDCA4>.)/", SyntaxError);
+assertTrue(/(?<\u0041>.)/.test("a"));
+assertThrows("/(?<\\u{0041}>.)/", SyntaxError);
+assertThrows("/(?<a\\u{104A4}>.)/", SyntaxError);
+assertThrows("/(?<a\\u{10FFFF}>.)/", SyntaxError);
+
 // @@replace with a callable replacement argument (no named captures).
 {
   let result = "abcd".replace(/(.)(.)/u, (match, fst, snd, offset, str) => {
     assertEquals("ab", match);
     assertEquals("a", fst);
     assertEquals("b", snd);
     assertEquals(0, offset);
     assertEquals("abcd", str);
     return `${snd}${fst}`;
   });
@@ skipping 166 matching lines @@
 // named captures).
 {
   let re = toSlowMode(/(?<fst>.)(?<snd>.)/u);
   assertEquals("bacd", "abcd".replace(re, "$<snd>$<fst>"));
   assertEquals("bacd", "abcd".replace(re, "$2$1"));
   assertThrows(() => "abcd".replace(re, "$<snd"), SyntaxError);
   assertEquals("cd", "abcd".replace(re, "$<42$1>"));
   assertEquals("cd", "abcd".replace(re, "$<thd>"));
   assertEquals("cd", "abcd".replace(re, "$<$1>"));
 }