[inspector] cache stack frame for call sites

src/objects.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/objects.h"
 
 #include <cmath>
 #include <iomanip>
 #include <memory>
 #include <sstream>
@@ skipping 2181 matching lines @@
     return Smi::FromInt(hash & Smi::kMaxValue);
   }
   if (object->IsName()) {
     uint32_t hash = Name::cast(object)->Hash();
     return Smi::FromInt(hash);
   }
   if (object->IsOddball()) {
     uint32_t hash = Oddball::cast(object)->to_string()->Hash();
     return Smi::FromInt(hash);
   }
+  if (object->IsByteArray()) {
+    ByteArray* array = ByteArray::cast(object);
+    int size = array->Size();
+    uint32_t hash = kZeroHashSeed;
+    uint32_t* data = reinterpret_cast<uint32_t*>(array->GetDataStartAddress());
+    for (int i = 0; i < size / 4; i += 4) {

[Yang, 2017/04/04 21:15:18]

Do we really need to hash the entire byte array? First and last word hashed
together sounds sufficient to me.

[kozy, 2017/04/04 23:08:12]

Done.

+      hash = ComputeIntegerHash(hash, *data);
+      ++data;
+    }
+    int tail_start = size - size % 4;
+    uint32_t tail = 0;
+    for (int i = tail_start; i < size; ++i) {
+      tail |= array->get(i);
+      tail <<= 8;
+    }
+    hash = ComputeIntegerHash(hash, tail);
+    return Smi::FromInt(hash);
+  }
   DCHECK(object->IsJSReceiver());
   // Simply return the receiver as it is guaranteed to not be a SMI.
   return object;
 }
 
 }  // namespace
 
 Object* Object::GetHash() {
   Object* hash = GetSimpleHash(this);
   if (hash->IsSmi()) return hash;
@@ skipping 18218 matching lines @@
       // depend on this.
       return DICTIONARY_ELEMENTS;
     }
     DCHECK_LE(kind, LAST_ELEMENTS_KIND);
     return kind;
   }
 }
 
 }  // namespace internal
 }  // namespace v8