Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4084)

Unified Diff: chrome/browser/engagement/site_engagement_service.h

Issue 2788413003: Add SiteEngagementService::GetAllDetails(), to return detailed scores. (Closed)
Patch Set: Cleanups Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_service.h
diff --git a/chrome/browser/engagement/site_engagement_service.h b/chrome/browser/engagement/site_engagement_service.h
index 35c005d1af69eefa392635567bbcf358f053b12c..16610bf60524f4d4837db13a64652c1221881a4b 100644
--- a/chrome/browser/engagement/site_engagement_service.h
+++ b/chrome/browser/engagement/site_engagement_service.h
@@ -8,6 +8,7 @@
#include <map>
#include <memory>
#include <set>
+#include <vector>
#include "base/gtest_prod_util.h"
#include "base/macros.h"
@@ -15,6 +16,7 @@
#include "base/observer_list.h"
#include "base/time/time.h"
#include "build/build_config.h"
+#include "chrome/browser/engagement/site_engagement_details.mojom.h"
#include "chrome/browser/engagement/site_engagement_metrics.h"
#include "chrome/browser/engagement/site_engagement_observer.h"
#include "components/history/core/browser/history_service_observer.h"
@@ -116,7 +118,13 @@ class SiteEngagementService : public KeyedService,
// Returns the engagement level of |url|.
blink::mojom::EngagementLevel GetEngagementLevel(const GURL& url) const;
+ // Returns an array of engagement score details for all origins which have
+ // a score, whether due to direct engagement, or other factors that cause
+ // an engagement bonus to be applied.
+ std::vector<mojom::SiteEngagementDetails> GetAllDetails() const;
+
// Returns a map of all stored origins and their engagement scores.
+ // TODO(wez): Replace calls to this with GetAllDetails()?
std::map<GURL, double> GetScoreMap() const;
// Update the engagement score of |url| for a notification interaction.
@@ -143,6 +151,9 @@ class SiteEngagementService : public KeyedService,
void HelperCreated(SiteEngagementService::Helper* helper);
void HelperDeleted(SiteEngagementService::Helper* helper);
+ // Returns the site engagement details for the specified |url|.
+ mojom::SiteEngagementDetails GetDetails(const GURL& url) const;
+
// Overridden from SiteEngagementScoreProvider.
double GetScore(const GURL& url) const override;
double GetTotalEngagementPoints() const override;

Powered by Google App Engine
This is Rietveld 408576698