Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: chrome/browser/resources/engagement/site_engagement.js

Issue 2788413003: Add SiteEngagementService::GetAllDetails(), to return detailed scores. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/engagement/site_engagement.js
diff --git a/chrome/browser/resources/engagement/site_engagement.js b/chrome/browser/resources/engagement/site_engagement.js
index e93cd1603ca6d08d42d03489ecafe3cafed455e1..cb9e0361b18380ca050fc11ab3a3c71a5b1c1b11 100644
--- a/chrome/browser/resources/engagement/site_engagement.js
+++ b/chrome/browser/resources/engagement/site_engagement.js
@@ -26,18 +26,18 @@ function notifyPagePopulated() {
}
define('main', [
- 'chrome/browser/engagement/site_engagement.mojom',
+ 'chrome/browser/engagement/site_engagement_details.mojom',
'content/public/renderer/frame_interfaces',
], function(siteEngagementMojom, frameInterfaces) {
return function() {
- var uiHandler = new siteEngagementMojom.SiteEngagementUIHandlerPtr(
+ var uiHandler = new siteEngagementMojom.SiteEngagementDetailsProviderPtr(
frameInterfaces.getInterface(
- siteEngagementMojom.SiteEngagementUIHandler.name));
+ siteEngagementMojom.SiteEngagementDetailsProvider.name));
var engagementTableBody = $('engagement-table-body');
var updateInterval = null;
var info = null;
- var sortKey = 'score';
+ var sortKey = 'base_score';
var sortReverse = true;
// Set table header sort handlers.
@@ -65,7 +65,7 @@ define('main', [
/**
* Creates a single row in the engagement table.
- * @param {SiteEngagementInfo} info The info to create the row from.
+ * @param {SiteEngagementDetails} info The info to create the row from.
* @return {HTMLElement}
*/
function createRow(info) {
@@ -77,13 +77,13 @@ define('main', [
'change', handleScoreChange.bind(undefined, info.origin));
scoreInput.addEventListener('focus', disableAutoupdate);
scoreInput.addEventListener('blur', enableAutoupdate);
- scoreInput.value = info.score;
+ scoreInput.value = info.base_score;
var scoreCell = createElementWithClassName('td', 'score-cell');
scoreCell.appendChild(scoreInput);
var engagementBar = createElementWithClassName('div', 'engagement-bar');
- engagementBar.style.width = (info.score * 4) + 'px';
+ engagementBar.style.width = (info.base_score * 4) + 'px';
var engagementBarCell =
createElementWithClassName('td', 'engagement-bar-cell');
@@ -145,7 +145,7 @@ define('main', [
}
/**
- * Compares two SiteEngagementInfo objects based on |sortKey|.
+ * Compares two SiteEngagementDetails objects based on |sortKey|.
* @param {string} sortKey The name of the property to sort by.
* @return {number} A negative number if |a| should be ordered before |b|, a
* positive number otherwise.
@@ -158,7 +158,7 @@ define('main', [
if (sortKey == 'origin')
return new URL(val1.url).host > new URL(val2.url).host ? 1 : -1;
- if (sortKey == 'score')
+ if (sortKey == 'base_score')
return val1 - val2;
assertNotReached('Unsupported sort key: ' + sortKey);
@@ -173,7 +173,7 @@ define('main', [
sortInfo();
// Round each score to 2 decimal places.
info.forEach(function(info) {
- info.score = Number(Math.round(info.score * 100) / 100);
+ info.base_score = Number(Math.round(info.base_score * 100) / 100);
engagementTableBody.appendChild(createRow(info));
});
@@ -185,7 +185,7 @@ define('main', [
*/
function updateEngagementTable() {
// Populate engagement table.
- uiHandler.getSiteEngagementInfo().then(function(response) {
+ uiHandler.getSiteEngagementDetails().then(function(response) {
info = response.info;
renderTable(info);
});

Powered by Google App Engine
This is Rietveld 408576698