Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3570)

Unified Diff: chrome/browser/engagement/site_engagement_service.h

Issue 2788413003: Add SiteEngagementService::GetAllDetails(), to return detailed scores. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_service.h
diff --git a/chrome/browser/engagement/site_engagement_service.h b/chrome/browser/engagement/site_engagement_service.h
index 7b9a5d936d14055a368380a74ae84d31b0631363..55b2826e86075adb89969084fa13700e1eebd6a9 100644
--- a/chrome/browser/engagement/site_engagement_service.h
+++ b/chrome/browser/engagement/site_engagement_service.h
@@ -15,6 +15,7 @@
#include "base/observer_list.h"
#include "base/time/time.h"
#include "build/build_config.h"
+#include "chrome/browser/engagement/site_engagement_details.mojom.h"
#include "chrome/browser/engagement/site_engagement_metrics.h"
#include "chrome/browser/engagement/site_engagement_observer.h"
#include "components/history/core/browser/history_service_observer.h"
@@ -111,7 +112,12 @@ class SiteEngagementService : public KeyedService,
// Returns the engagement level of |url|.
blink::mojom::EngagementLevel GetEngagementLevel(const GURL& url) const;
+ // Returns SiteEngagementDetails structures describing the score details for
+ // all stored origins.
+ std::vector<mojom::SiteEngagementDetails> GetScoreDetails() const;
+
// Returns a map of all stored origins and their engagement scores.
+ // TODO(wez): Remove this!
std::map<GURL, double> GetScoreMap() const;
// Update the engagement score of |url| for a notification interaction.
@@ -138,6 +144,9 @@ class SiteEngagementService : public KeyedService,
void HelperCreated(SiteEngagementService::Helper* helper);
void HelperDeleted(SiteEngagementService::Helper* helper);
+ // Returns the site engagement details for the specified |url|.
+ mojom::SiteEngagementDetails GetScoreDetails(const GURL& url) const;
+
// Overridden from SiteEngagementScoreProvider.
double GetScore(const GURL& url) const override;
double GetTotalEngagementPoints() const override;

Powered by Google App Engine
This is Rietveld 408576698