Add SiteEngagementService::GetAllDetails(), to return detailed scores.

chrome/browser/engagement/site_engagement_service_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/engagement/site_engagement_service.h"
 
 #include <utility>
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
@@ skipping 1817 matching lines @@
 
   EXPECT_EQ(3, CheckScoreFromSettingsOnThread(content::BrowserThread::IO,
                                               settings_map, url1));
   EXPECT_EQ(3, CheckScoreFromSettingsOnThread(content::BrowserThread::FILE,
                                               settings_map, url2));
   EXPECT_EQ(4, CheckScoreFromSettingsOnThread(content::BrowserThread::FILE,
                                               incognito_settings_map, url1));
   EXPECT_EQ(3, CheckScoreFromSettingsOnThread(content::BrowserThread::IO,
                                               incognito_settings_map, url2));
 }
+
+TEST_F(SiteEngagementServiceTest, GetAllDetailsIncludesBonusOnlyScores) {
+  GURL url1("http://www.google.com/");
+  GURL url2("https://www.google.com/");
+  GURL url3("https://drive.google.com/");
+
+  std::vector<mojom::SiteEngagementDetails> details = service_->GetAllDetails();
+  EXPECT_EQ(0u, details.size());
+
+  // Add a single site score via explicitly resetting the engagement score.
+  service_->ResetBaseScoreForURL(url1, 5);
+
+  // Add a second site indirectly, via notifications permissions.
+  HostContentSettingsMap* settings_map =
+      HostContentSettingsMapFactory::GetForProfile(profile());
+  settings_map->SetContentSettingDefaultScope(
+      url2, url2, CONTENT_SETTINGS_TYPE_NOTIFICATIONS, std::string(),

[dominickn, 2017/04/10 04:49:26]

Nit: this second url2 should be GURL(). Notifications doesn't use the secondary
pattern.

[Wez, 2017/04/10 21:18:09]

This was actually cribbed from the tests above. :P

Done.

+      CONTENT_SETTING_ALLOW);
+
+  // Add a third site with notifications permission explicitly denied, to verify
+  // that it is not included.
+  settings_map->SetContentSettingDefaultScope(
+      url3, url3, CONTENT_SETTINGS_TYPE_NOTIFICATIONS, std::string(),

[dominickn, 2017/04/10 04:49:26]

Ditto

[Wez, 2017/04/10 21:18:09]

Done.

+      CONTENT_SETTING_BLOCK);
+
+  // Verify that the URLs with engagement, and with notifications permission
+  // boosted engagement total, are included.
+  details = service_->GetAllDetails();
+  EXPECT_EQ(2u, details.size());
+}