tests/compiler/dart2js/warnings_checker.dart - Issue 2788373002: Add Source.getTextLine and use it to display source snippets in error messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/warnings_checker.dart

Issue 2788373002: Add Source.getTextLine and use it to display source snippets in error messages. (Closed)

Patch Set: dartfmt Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/warnings_checker.dart

diff --git a/tests/compiler/dart2js/warnings_checker.dart b/tests/compiler/dart2js/warnings_checker.dart

index 8e6d531aff6139c84bdc64239c772fe927b1ffcd..d6009710a8d9d6cd6013ecbb8dc02de48d0fb0e2 100644

--- a/tests/compiler/dart2js/warnings_checker.dart

+++ b/tests/compiler/dart2js/warnings_checker.dart

@@ -59,7 +59,7 @@ void checkWarnings(Map<String, dynamic> tests, [List<String> arguments]) {

}

for (CollectedMessage message in collector.warnings) {

Expect.equals(uri, message.uri);

- int lineNo = file.getLine(message.begin);

+ int lineNo = file.getLocation(message.begin).line - 1;

if (expectedWarnings.containsKey(lineNo)) {

unseenWarnings.remove(lineNo);

} else if (!unexpectedStatus.contains(lineNo + 1)) {