tests/compiler/dart2js/sourcemaps/diff_view.dart - Issue 2788373002: Add Source.getTextLine and use it to display source snippets in error messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/sourcemaps/diff_view.dart

Issue 2788373002: Add Source.getTextLine and use it to display source snippets in error messages. (Closed)

Patch Set: dartfmt Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/sourcemaps/diff_view.dart

diff --git a/tests/compiler/dart2js/sourcemaps/diff_view.dart b/tests/compiler/dart2js/sourcemaps/diff_view.dart

index e1b0158e68a4622a826bbea335de3aab0deaa15b..f84b8c5711bffb33301eab4fe90e82bba2bc5af4 100644

--- a/tests/compiler/dart2js/sourcemaps/diff_view.dart

+++ b/tests/compiler/dart2js/sourcemaps/diff_view.dart

@@ -852,7 +852,8 @@ Future<CodeLinesResult> computeCodeLines(

sourceMaps.elementSourceMapInfos

.forEach((Element element, SourceMapInfo info) {

CodePosition position = info.jsCodePositions[info.node];

- elementMap[sourceFile.getLine(position.startPosition)] = element;

+ elementMap[sourceFile.getLocation(position.startPosition).line - 1] =

+ element;

});

codeLines = convertAnnotatedCodeToCodeLines(code, annotations);