Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: tests/compiler/dart2js/source_map_validator_helper.dart

Issue 2788373002: Add Source.getTextLine and use it to display source snippets in error messages. (Closed)
Patch Set: dartfmt Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/source_map_validator_helper.dart
diff --git a/tests/compiler/dart2js/source_map_validator_helper.dart b/tests/compiler/dart2js/source_map_validator_helper.dart
index 7fe628d81df73e78495570319abfbcb74b22f942..3e24a80f3be1b1feb2e65da55c75480255623cb5 100644
--- a/tests/compiler/dart2js/source_map_validator_helper.dart
+++ b/tests/compiler/dart2js/source_map_validator_helper.dart
@@ -22,6 +22,7 @@ import 'package:compiler/src/elements/elements.dart'
import 'package:compiler/src/io/source_file.dart' show SourceFile;
import 'package:compiler/src/io/source_information.dart'
show computeElementNameForSourceMaps;
+import 'package:kernel/ast.dart' show Location;
validateSourceMap(Uri targetUri,
{Uri mainUri, Position mainPosition, CompilerImpl compiler}) {
@@ -132,8 +133,9 @@ checkNames(
SourceFile sourceFile = compilationUnit.script.file;
Position positionFromOffset(int offset) {
- int line = sourceFile.getLine(offset);
- int column = sourceFile.getColumn(line, offset);
+ Location location = sourceFile.getLocation(offset);
+ int line = location.line - 1;
+ int column = location.column - 1;
return new Position(line, column);
}

Powered by Google App Engine
This is Rietveld 408576698