Add Source.getTextLine and use it to display source snippets in error messages.

pkg/compiler/lib/src/io/source_file.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.io.source_file;
 
 import 'dart:convert' show UTF8;
 import 'dart:math';
 import 'dart:typed_data' show Uint8List;
 
+import 'package:kernel/ast.dart' as kernel show Location, Source;
+
 import 'line_column_provider.dart';
 
 /**
  * Represents a file of source code. The content can be either a [String] or
  * a UTF-8 encoded [List<int>] of bytes.
  */
 abstract class SourceFile implements LineColumnProvider {
   /// The absolute URI of the source file.
   Uri get uri;
 
+  kernel.Source cachedKernelSource;
+
+  kernel.Source get kernelSource {
+    return cachedKernelSource ??= new kernel.Source(
+        lineStarts, slowUtf8ZeroTerminatedBytes())..cachedText = slowText();
+  }
+
   /// The name of the file.
   ///
   /// This is [uri], maybe relativized to a more human-readable form.
   String get filename => uri.toString();
 
   /** The text content of the file represented as a String. */
   String slowText();
 
   /**
    * The content of the file represented as a UTF-8 encoded [List<int>],
@@ skipping 48 matching lines @@
     }
     starts.add(text.length + 1); // One additional line start at the end.
     return starts;
   }
 
   /**
    * Returns the line number for the offset [position] in the string
    * representation of this source file.
    */
   int getLine(int position) {
-    List<int> starts = lineStarts;
-    if (position < 0 || starts.last <= position) {
-      throw 'bad position #$position in file $filename with '
-          'length ${length}.';
-    }
-    int first = 0;
-    int count = starts.length;
-    while (count > 1) {
-      int step = count ~/ 2;
-      int middle = first + step;
-      int lineStart = starts[middle];
-      if (position < lineStart) {
-        count = step;
-      } else {
-        first = middle;
-        count -= step;
-      }
-    }
-    return first;
+    new kernel.Source(lineStarts, null).getLocation(null, position).line;
   }
 
   /**
    * Returns the column number for the offset [position] in the string
    * representation of this source file.
    */
   int getColumn(int line, int position) {
     return position - lineStarts[line];
   }
 
@@ skipping 16 matching lines @@
   String getLocationMessage(String message, int start, int end,
       {bool includeSourceLine: true, String colorize(String text)}) {
     if (colorize == null) {
       colorize = (text) => text;
     }
     if (end > length) {
       start = length - 1;
       end = length;
     }
 
-    int lineStart = getLine(start);
-    int columnStart = getColumn(lineStart, start);
-    int lineEnd = getLine(end);
-    int columnEnd = getColumn(lineEnd, end);
+    kernel.Location startLocation = kernelSource.getLocation(null, start);
+    kernel.Location endLocation = kernelSource.getLocation(null, end);
+    int lineStart = startLocation.line - 1;
+    int columnStart = startLocation.column - 1;
+    int lineEnd = startLocation.line - 1;
+    int columnEnd = endLocation.column - 1;
 
     StringBuffer buf = new StringBuffer('${filename}:');
     if (start != end || start != 0) {
       // Line/column info is relevant.
       buf.write('${lineStart + 1}:${columnStart + 1}:');
     }
     buf.write('\n$message\n');
 
     if (start != end && includeSourceLine) {
       if (lineStart == lineEnd) {
-        String textLine = getLineText(lineStart);
+        String textLine = kernelSource.getTextLine(startLocation.line);
 
         int toColumn = min(columnStart + (end - start), textLine.length);
         buf.write(textLine.substring(0, columnStart));
         buf.write(colorize(textLine.substring(columnStart, toColumn)));
-        buf.write(textLine.substring(toColumn));
+        buf.writeln(textLine.substring(toColumn));
 
         int i = 0;
         for (; i < columnStart; i++) {
           buf.write(' ');
         }
 
         for (; i < toColumn; i++) {
           buf.write(colorize('^'));
         }
       } else {
         for (int line = lineStart; line <= lineEnd; line++) {
-          String textLine = getLineText(line);
+          String textLine = kernelSource.getTextLine(line + 1);
           if (line == lineStart) {
             buf.write(textLine.substring(0, columnStart));
-            buf.write(colorize(textLine.substring(columnStart)));
+            buf.writeln(colorize(textLine.substring(columnStart)));
           } else if (line == lineEnd) {
             buf.write(colorize(textLine.substring(0, columnEnd)));
-            buf.write(textLine.substring(columnEnd));
+            buf.writeln(textLine.substring(columnEnd));
           } else {
-            buf.write(colorize(textLine));
+            buf.writeln(colorize(textLine));
           }
         }
       }
     }
 
     return buf.toString();
   }
 
   int get lines => lineStarts.length - 1;
 
-  /// Returns the text of line  at the 0-based [index] within this source file.
-  String getLineText(int index) {
-    // +1 for 0-indexing, +1 again to avoid the last line of the file
-    if ((index + 2) < lineStarts.length) {
-      return slowSubstring(lineStarts[index], lineStarts[index + 1]);
-    } else if ((index + 1) < lineStarts.length) {
-      return '${slowSubstring(lineStarts[index], length)}\n';
-    } else {
-      throw new ArgumentError("Line index $index is out of bounds.");
-    }
-  }
+  /// Returns the text of line at the 0-based [index] within this source
+  /// file. The returned line always ends with `"\n"`.
+  String getLineText(int index) => kernelSource.getTextLine(line) + "\n";
 }
 
 List<int> _zeroTerminateIfNecessary(List<int> bytes) {
   if (bytes.length > 0 && bytes.last == 0) return bytes;
   List<int> result = new Uint8List(bytes.length + 1);
   result.setRange(0, bytes.length, bytes);
   result[result.length - 1] = 0;
   return result;
 }
 
@@ skipping 70 matching lines @@
   set length(int v) {}
 
   String slowText() => text;
 
   List<int> slowUtf8ZeroTerminatedBytes() {
     return _zeroTerminateIfNecessary(UTF8.encode(text));
   }
 
   String slowSubstring(int start, int end) => text.substring(start, end);
 }