Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4495)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java

Issue 2788343002: Translate page in the new UI. (Closed)
Patch Set: refactor Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java
index 5b77a4bc7c64da279ea7c69e418fc103f6a154ee..87e0a1664cb01d716f74ba45dd2185d88e7ce056 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java
@@ -91,8 +91,6 @@ public class TranslateTabLayout extends TabLayout {
}
mTabShowingProgressBar = getTabAt(tabPos);
- mTabShowingProgressBar.select();
-
// TODO(martiw) See if we need to setContentDescription as "Translating" here.
if (tabIsSupported(mTabShowingProgressBar)) {
@@ -100,6 +98,19 @@ public class TranslateTabLayout extends TabLayout {
}
}
+ /**
+ * Hide the present spinning progress bar in the tabs.
+ */
+ public void hidePresentProgressBar() {
gone 2017/04/04 18:44:38 What's a "present progress bar"?
Leo 2017/04/05 08:37:47 Removed "present"
+ if (mTabShowingProgressBar != null) {
gone 2017/04/04 18:44:38 Save a level of indentation by early returning. i
Leo 2017/04/05 08:37:47 Acknowledged.
+ if (tabIsSupported(mTabShowingProgressBar)) {
+ ((TranslateTabContent) mTabShowingProgressBar.getCustomView()).hideProgressBar();
+ }
+
+ mTabShowingProgressBar = null;
+ }
+ }
+
/** Stop the spinning progress bar. */
public void stopProgressBarAndRevertBack() {
if (mTabShowingProgressBar == null) {

Powered by Google App Engine
This is Rietveld 408576698