Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3019)

Unified Diff: components/security_interstitials/core/browser/resources/interstitial_v2_mobile.js

Issue 2788323002: SafeBrowsing: update interstitial layouts (Closed)
Patch Set: Rebase off master Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_interstitials/core/browser/resources/interstitial_v2_mobile.js
diff --git a/components/security_interstitials/core/browser/resources/interstitial_v2_mobile.js b/components/security_interstitials/core/browser/resources/interstitial_v2_mobile.js
index f296232387cf887bd5a238f8e53f0f30f26ce556..01dc05dc7603a0d621de2933e8563ef8928d8da6 100644
--- a/components/security_interstitials/core/browser/resources/interstitial_v2_mobile.js
+++ b/components/security_interstitials/core/browser/resources/interstitial_v2_mobile.js
@@ -12,10 +12,9 @@ function onResize() {
var helpOuterBox = document.querySelector('#details');
var mainContent = document.querySelector('#main-content');
var mediaQuery = '(min-width: 240px) and (max-width: 420px) and ' +
- '(max-height: 736px) and (min-height: 401px) and ' +
- '(orientation: portrait), (max-width: 736px) and ' +
- '(max-height: 420px) and (min-height: 240px) and ' +
- '(min-width: 421px) and (orientation: landscape)';
+ '(min-height: 401px), ' +
+ '(max-height: 640px) and (min-height: 240px) and ' +
edwardjung 2017/04/21 12:16:30 This max-height should match the value used in the
Nate Fischer 2017/04/21 18:28:43 Done. I couldn't see a difference either way--I'll
edwardjung 2017/04/24 10:30:40 No difference to the SSL, malware interstitials. T
+ '(min-width: 421px)';
var detailsHidden = helpOuterBox.classList.contains('hidden');
var runnerContainer = document.querySelector('.runner-container');

Powered by Google App Engine
This is Rietveld 408576698