Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 278823004: Make DesktopWindowTreeHostX11::use_native_frame_ more robust (Closed)

Created:
6 years, 7 months ago by pkotwicz
Modified:
6 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Visibility:
Public.

Description

Make |DesktopWindowTreeHostX11::use_native_frame_| more robust. In particular, this CL ensures that widgets which expect to use the native frame (e.g. v2 apps, task manager) continue to do so even if DesktopWindowTreeHostX11::FrameTypeChanged() is called. BUG=348437 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271986

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pkotwicz
erg@ PTAL I realize that things would not work if a caller called Widget::set_frame_type(Widget::FRAME_TYPE_FORCE_CUSTOM); Widget::set_frame_type(Widget::FRAME_TYPE_DEFAULT); ...
6 years, 7 months ago (2014-05-13 00:11:53 UTC) #1
Elliot Glaysher
lgtm
6 years, 7 months ago (2014-05-13 00:19:03 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 7 months ago (2014-05-20 17:15:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/278823004/40001
6 years, 7 months ago (2014-05-20 17:17:57 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 21:24:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 22:29:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/155545)
6 years, 7 months ago (2014-05-20 22:29:53 UTC) #7
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 7 months ago (2014-05-21 00:08:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/278823004/40001
6 years, 7 months ago (2014-05-21 00:09:59 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 20:02:10 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 22:25:15 UTC) #11
Message was sent while issue was closed.
Change committed as 271986

Powered by Google App Engine
This is Rietveld 408576698