Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: content/renderer/input/main_thread_event_queue_task_list.cc

Issue 2788203002: Adjust cancelabilty of touchmoves that are queued when scroll start occurs (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/input/main_thread_event_queue_task_list.cc
diff --git a/content/renderer/input/main_thread_event_queue_task_list.cc b/content/renderer/input/main_thread_event_queue_task_list.cc
index d45a944de5f61c26ec14af6e92886408f29a3b72..58045942298a73a8d4805015c5bab5c18e132f09 100644
--- a/content/renderer/input/main_thread_event_queue_task_list.cc
+++ b/content/renderer/input/main_thread_event_queue_task_list.cc
@@ -14,12 +14,12 @@ void MainThreadEventQueueTaskList::Queue(
std::unique_ptr<MainThreadEventQueueTask> event) {
for (auto last_event_iter = queue_.rbegin(); last_event_iter != queue_.rend();
++last_event_iter) {
- switch ((*last_event_iter)->CoalesceWith(*event.get())) {
- case MainThreadEventQueueTask::CoalesceResult::Coalesced:
+ switch ((*last_event_iter)->NotifyEventWillBeQueued(*event.get())) {
+ case MainThreadEventQueueTask::NotifyResult::CoalescedEvent:
return;
- case MainThreadEventQueueTask::CoalesceResult::CannotCoalesce:
+ case MainThreadEventQueueTask::NotifyResult::Stop:
tdresser 2017/03/31 19:31:02 I found "CannotCoalesce" a bit clearer here. Why t
dtapuska 2017/03/31 20:18:18 As discussed in person it covers a few scenarios.
break;
- case MainThreadEventQueueTask::CoalesceResult::KeepSearching:
+ case MainThreadEventQueueTask::NotifyResult::KeepIterating:
continue;
}
break;

Powered by Google App Engine
This is Rietveld 408576698